Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Story Points:4
-
Epic Link:
-
Team:Alert Production
Description
lsst.afw.math still has a mathLib file, a relic from the early days of pybind11 wrapping. This file is confusingly referred to from several Python files (which likely need only import a sibling module), and confuses automodapi. Do any cleanup needed to let this file be removed.
Attachments
Issue Links
Activity
Matthias Wittgen, it looks like you gave the review to both Jim Bosch and me. How would you like us to divide up the work?
Krzysztof Findeisen
added a comment - Matthias Wittgen , it looks like you gave the review to both Jim Bosch and me. How would you like us to divide up the work? Removed Jim for now.
Matthias Wittgen
added a comment - Removed Jim for now. I've created and reviewed afw#557. In the future, please create a pull request yourself per DM procedure, as this makes the review process go more smoothly.
The work done on this ticket only covers removal of mathLib, and not modernization of the individual wrappers, so I suggest opening another issue for that.
Krzysztof Findeisen
added a comment - - edited I've created and reviewed afw#557 . In the future, please create a pull request yourself per DM procedure , as this makes the review process go more smoothly.
The work done on this ticket only covers removal of mathLib , and not modernization of the individual wrappers, so I suggest opening another issue for that. 
It looks like we don't have a ticket for upgrading afw.math to the new pybind11 wrapper system (like
DM-20286andDM-20703for other afw subpackages). I think it makes sense to do that on this ticket, as otherwise that woiuld break any other changes that are made on this ticket.(I'm updating this now because I think there's a reasonable chance that Matthias Wittgen, a new DRP member, might steal it - and
DM-20703- before Krzysztof Findeisen gets to them).