Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ctrl_mpexec
-
Labels:
-
Story Points:0.3
-
Epic Link:
-
Sprint:BG3_F18_11
-
Team:Data Access and Database
Description
DM-16904 changed the api of adaptArgsAndRun (this commit) but examples/calexpToCoaddTask.py in pipe_supertask wasn't updated (this line). Hence CalexpToCoaddTask no longer works.
result = task.runQuantum(quantum, butler)
|
File "/software/lsstsw/stack_20181012/stack/miniconda3-4.5.4-fcd27eb/Linux64/pipe_base/16.0-21-g91a1c50+2/python/lsst/pipe/base/pipelineTask.py", line 502, in runQuantum
|
struct = self.adaptArgsAndRun(inputs, inputDataIds, outputDataIds, butler)
|
TypeError: adaptArgsAndRun() takes 4 positional arguments but 5 were given
|
Attachments
Issue Links
- is triggered by
-
DM-16904 Pass butler object to adaptArgsAndRun in PipelineTask
- Done
Activity
Fix is trivial, so I self-reviewed and merged it. Example task runs OK now:
$ pipetask -b $CI_HSC_DIR/DATA/butler.yaml -i shared/ci_hsc -o coll-Z -d "Patch.patch=54" run -t rawToCalexpTask.RawToCalexpTask -t calexpToCoaddTask.CalexpToCoaddTask
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13fd4f2c00>]
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13fd4e8b90>]
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13db578618>]
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13fd4865a8>]
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13e23ffd50>]
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13d88e90d8>]
|
ctrl.mpexec.examples.rawToCalexpTask INFO: executing RawToCalexpTask: input=[<lsst.afw.image.exposure.exposure.ExposureU object at 0x7f13e24073e8>]
|
ctrl.mpexec.examples.calexpToCoaddTask INFO: executing calexpToCoaddTask: calexp=[DataId({instrument: HSC, detector: 17, visit: 903988}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion})), DataId({instrument: HSC, detector: 16, visit: 903986}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion})), DataId({instrument: HSC, detector: 18, visit: 903990}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion}))] coadd={abstract_filter: i, skymap: ci_hsc, tract: 0, patch: 54}
|
ctrl.mpexec.examples.calexpToCoaddTask INFO: executing calexpToCoaddTask: calexp=[DataId({instrument: HSC, detector: 16, visit: 903334}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion})), DataId({instrument: HSC, detector: 18, visit: 903338}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion})), DataId({instrument: HSC, detector: 0, visit: 903344}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion})), DataId({instrument: HSC, detector: 17, visit: 903336}, dimensions=DimensionGraph({Instrument, Detector, Visit}, joins={VisitDetectorRegion}))] coadd={abstract_filter: r, skymap: ci_hsc, tract: 0, patch: 54}
|
Hsin-Fang Chiang, thanks for report, this should be easy to fix. Note that pipe_supertask should not be used anymore, we have ctrl_mpexec as its replacement, and stac is replaced by pipetask.