Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_drivers
-
Labels:None
-
Team:External
Description
Michitaro Koike points out that SkyMeasurementTask.measureScale uses zip to iterate over x and y limits, so it's only iterating over the diagonal of the image. He sent a patch which I'll clean up and shepherd through.
Attachments
Activity
Jenkins run (before squashing commits): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29233/pipeline/
Paul Price
added a comment - Jenkins run (before squashing commits): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29233/pipeline/ One last tiny thing to consider and I think it is good.
Jenkins run after functional changes: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29261/pipeline/47
I'm going to add the requested comment, then merge.
Paul Price
added a comment - Jenkins run after functional changes: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29261/pipeline/47
I'm going to add the requested comment, then merge. Merged to master.
Thanks for the help, Nate Lust!
Paul Price
added a comment - Merged to master.
Thanks for the help, Nate Lust ! 
Nate Lust, would you mind looking this over, please?
price@MacBook:~/LSST/pipe_drivers (tickets/DM-17098=) $ git subcommit 59900dd5a79a6124e5910c072533ea144fa3a511 (HEAD -> tickets/DM-17098, origin/tickets/DM-17098)Author: michitaro <michitaro.nike@gmail.com>Date: Thu Jan 10 18:21:34 2019 +0900fix SkyMeasurementTask.measureScaleSkyMeasurementTask.measureScale uses zip to iterate over x and ylimits, so it's only iterating over the diagonal of the image.Using itertools.product, we iterate over the entire image.python/lsst/pipe/drivers/background.py | 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)