Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17122

Complete Milestone LDM-503-10 (DAQ Validation)

    Details

    • Type: Story
    • Status: Reviewed
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Team:
      Data Facility

      Attachments

        Activity

        swinbank John Swinbank created issue -
        swinbank John Swinbank made changes -
        Field Original Value New Value
        Due Date 31/Oct/19
        swinbank John Swinbank made changes -
        Due Date 31/Oct/19 05/Nov/19
        swinbank John Swinbank made changes -
        Due Date 05/Nov/19 11/Nov/19
        swinbank John Swinbank made changes -
        Due Date 11/Nov/19 01/Sep/20
        swinbank John Swinbank made changes -
        Due Date 01/Sep/20 05/Nov/19
        swinbank John Swinbank made changes -
        Due Date 05/Nov/19 31/Oct/19
        swinbank John Swinbank made changes -
        Summary Complete Milestone LDM-503-10 Complete Milestone LDM-503-10 (DAQ Validation)
        swinbank John Swinbank made changes -
        Due Date 31/Oct/19 29/May/20
        swinbank John Swinbank made changes -
        Due Date 29/May/20 22/Jun/20
        mbutler Michelle Butler made changes -
        Status To Do [ 10001 ] In Progress [ 3 ]
        Show
        mbutler Michelle Butler added a comment - https://dmtr-181.lsst.io/v/DM-17122/index.html  
        mbutler Michelle Butler made changes -
        Reviewers Leanne Guy, Wil O'Mullane [ lguy, womullan ]
        Status In Progress [ 3 ] In Review [ 10004 ]
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        PR available for comments: https://github.com/lsst-dm/DMTR-181/pull/1

        Show
        gcomoretto Gabriele Comoretto added a comment - PR available for comments:  https://github.com/lsst-dm/DMTR-181/pull/1
        Hide
        lguy Leanne Guy added a comment - - edited

        I have left some comments in the PR . Some additional comments

        • 1.3 Applicable Documents
          Should also contain LDM-639, this is where the Test Cases are baselined
        • ComCam, comcam, etc
          Inconsistent throughout the document. I think we have settled on "ComCam"?
        • MTcam is not defined

        Looks good provided these comments and those in the PR are addressed

        Show
        lguy Leanne Guy added a comment - - edited I have left some comments in the PR . Some additional comments 1.3 Applicable Documents Should also contain LDM-639, this is where the Test Cases are baselined ComCam, comcam, etc Inconsistent throughout the document. I think we have settled on "ComCam"? MTcam is not defined Looks good provided these comments and those in the PR are addressed
        lguy Leanne Guy made changes -
        Status In Review [ 10004 ] Reviewed [ 10101 ]
        lguy Leanne Guy made changes -
        Reviewers Leanne Guy, Wil O'Mullane [ lguy, womullan ] Wil O'Mullane [ womullan ]
        lguy Leanne Guy made changes -
        Status Reviewed [ 10101 ] In Review [ 10004 ]
        Hide
        mbutler Michelle Butler added a comment -

        updated document with the edits here and from Leanne.  Gabriele Comoretto can you regenerate?  

         

        Show
        mbutler Michelle Butler added a comment - updated document with the edits here and from Leanne.  Gabriele Comoretto can you regenerate?    
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        DMTR-181 regenerated in this ticket branch.

        Show
        gcomoretto Gabriele Comoretto added a comment - DMTR-181 regenerated in this ticket branch.
        Hide
        womullan Wil O'Mullane added a comment -

        I am confused this ticket branch still says not executed ..

        Show
        womullan Wil O'Mullane added a comment - I am confused this ticket branch still says not executed ..
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        The problem was that there are 2 extra executions recorded in the test player, and the last one is marked as Not Executed.

        I updated docsteady on the fly in order to handle this situation and I regenerated DMTR including the correct results.

        I open a Jira issue to fix docsteady and include a couple of more fixes.

        Show
        gcomoretto Gabriele Comoretto added a comment - The problem was that there are 2 extra executions recorded in the test player, and the last one is marked as Not Executed. I updated docsteady on the fly in order to handle this situation and I regenerated DMTR including the correct results. I open a Jira issue to fix docsteady and include a couple of more fixes.
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        Michelle Butler, you should set the status of the test cycle LVV-C107 to Done, in case all test steps have been completed, as it looks like.

        Show
        gcomoretto Gabriele Comoretto added a comment - Michelle Butler , you should set the status of the test cycle LVV-C107 to Done , in case all test steps have been completed, as it looks like.
        Hide
        mbutler Michelle Butler added a comment -

        done. Thanks Gabriele Comoretto

        Show
        mbutler Michelle Butler added a comment - done. Thanks Gabriele Comoretto
        Hide
        mbutler Michelle Butler added a comment -

        is this still being reviewed?   Just trying to put them down in the monthly report.  

        Show
        mbutler Michelle Butler added a comment - is this still being reviewed?   Just trying to put them down in the monthly report.  
        Hide
        lguy Leanne Guy added a comment -

        Just spoke to Gabriele Comoretto – he has fixed docsteady so that only the 'executed' tests that were run appear in the DMTR. The additional executions are a atlassian/jira issue. I am satisfied that this Milestone has been correctly tested

        Show
        lguy Leanne Guy added a comment - Just spoke to Gabriele Comoretto – he has fixed docsteady so that only the 'executed' tests that were run appear in the DMTR. The additional executions are a atlassian/jira issue. I am satisfied that this Milestone has been correctly tested
        lguy Leanne Guy made changes -
        Status In Review [ 10004 ] Reviewed [ 10101 ]
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        I will proceed with the final steps to issue the document in Docushare. I am going to set the status of the LVV-P64 to "Completed".

        Show
        gcomoretto Gabriele Comoretto added a comment - I will proceed with the final steps to issue the document in Docushare. I am going to set the status of the LVV-P64 to "Completed".
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        Michelle Butler just a last check on the changelog entry at https://dmtr-181.lsst.io/v/DM-17122/index.html I just added. Let me know in case you want me to change it.

        Show
        gcomoretto Gabriele Comoretto added a comment - Michelle Butler just a last check on the changelog entry at https://dmtr-181.lsst.io/v/DM-17122/index.html  I just added. Let me know in case you want me to change it.
        Hide
        gcomoretto Gabriele Comoretto added a comment -

        Document finalized.

        Show
        gcomoretto Gabriele Comoretto added a comment - Document finalized.

          People

          • Assignee:
            mbutler Michelle Butler
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Wil O'Mullane
            Watchers:
            Gabriele Comoretto, John Swinbank, Leanne Guy, Michelle Butler, Wil O'Mullane
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:

              Summary Panel