Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17124

Complete Milestone LDM-503-11 (Ops rehearsal for commissioning #2)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Team:
      Data Facility
    • Urgent?:
      No

      Attachments

      1. Fig2_noTitle.png
        Fig2_noTitle.png
        1.93 MB
      2. Fig2_withTitle.png
        Fig2_withTitle.png
        1.95 MB
      3. Fig3_noTitle.png
        Fig3_noTitle.png
        1.06 MB
      4. Fig3_withTitle.png
        Fig3_withTitle.png
        1.07 MB

        Issue Links

          Activity

          Hide
          gruendl Robert Gruendl added a comment -

          Not sure what counts for evidence of completion but I think it stands as the report (DMTN-159) which is finished.  So we would like to claim this to be done.

           

          Show
          gruendl Robert Gruendl added a comment - Not sure what counts for evidence of completion but I think it stands as the report (DMTN-159) which is finished.  So we would like to claim this to be done.  
          Hide
          lguy Leanne Guy added a comment - - edited

          Page 1:

          • projectshared/comCam => /project/shared/comCam
          • Processing was accomplished using ... -> can you add a link somewhere in the document to the exact run instructions and pipeline configuration that Monika provided during the ope rehearsal. Perhaps linking the github repo with Monika's scripts and Lauren's notebooks is best: https://github.com/lsst-dm/OPS_Rehearsal_2
          • Which version of the science piplines used? (for processBias.py, processFlat.py, etc )

          Page 2:

          • The calibrations frames -> The calibration frames

          Page 5:

          • Titles "old" and "new" on the figures are not informative and should be updated to reflect what is different between them
          • SSD is not in the acronym list

          Page 6:

          • As above "new" on Figure 3 is not informative. Please remove or replace with informative text

          Page 7:
          " discussing this in September and should set a goal to be able to switch to using the Gen3 Butler and code-base (with high priority)." => I think we agreed that there was no point doing another OR if we couldn't use Gen3. Gen 3 for general use is planned for Nov, so maybe it would be better to say something like "on the November timeframe after Gen 3 is released for general use", and to be clear that the next OR must use Gen3.

          General comments

          • Many problems are discussed in the document. Were there any Jira tickets generated to look into issues that arose? If so, it would be good to list them.
          • In the OR2 github repo, Lauren's notebooks should be merged to master.
          Show
          lguy Leanne Guy added a comment - - edited Page 1: projectshared/comCam => /project/shared/comCam Processing was accomplished using ... -> can you add a link somewhere in the document to the exact run instructions and pipeline configuration that Monika provided during the ope rehearsal. Perhaps linking the github repo with Monika's scripts and Lauren's notebooks is best: https://github.com/lsst-dm/OPS_Rehearsal_2 Which version of the science piplines used? (for processBias.py, processFlat.py, etc ) Page 2: The calibrations frames -> The calibration frames Page 5: Titles "old" and "new" on the figures are not informative and should be updated to reflect what is different between them SSD is not in the acronym list Page 6: As above "new" on Figure 3 is not informative. Please remove or replace with informative text Page 7: " discussing this in September and should set a goal to be able to switch to using the Gen3 Butler and code-base (with high priority)." => I think we agreed that there was no point doing another OR if we couldn't use Gen3. Gen 3 for general use is planned for Nov, so maybe it would be better to say something like "on the November timeframe after Gen 3 is released for general use", and to be clear that the next OR must use Gen3. General comments Many problems are discussed in the document. Were there any Jira tickets generated to look into issues that arose? If so, it would be good to list them. In the OR2 github repo, Lauren's notebooks should be merged to master.
          Hide
          lauren Lauren MacArthur added a comment -

          I have pushed my notebook branch to master on https://github.com/lsst-dm/OPS_Rehearsal_2

          As for the plot labels, "old" refers to the original processing run where the wrong biases were being applied and "new" refers to the updated processing run which used the correct biases. This could be noted in the captions, e.g.:

          Figure 2: Left: Night 2 dark with incorrect (i.e. "old") bias subtracted. Right: Night 2 dark with correct (i.e. "new") bias subtracted.
          

          Or, if preferred, I could provide updated versions with any title you suggest (and, of course, if you'd rather the titles be left off entirely, that can easily be done with cropping).

          Show
          lauren Lauren MacArthur added a comment - I have pushed my notebook branch to master on https://github.com/lsst-dm/OPS_Rehearsal_2 As for the plot labels, "old" refers to the original processing run where the wrong biases were being applied and "new" refers to the updated processing run which used the correct biases. This could be noted in the captions, e.g.: Figure 2: Left: Night 2 dark with incorrect (i.e. "old") bias subtracted. Right: Night 2 dark with correct (i.e. "new") bias subtracted. Or, if preferred, I could provide updated versions with any title you suggest (and, of course, if you'd rather the titles be left off entirely, that can easily be done with cropping).
          Hide
          lguy Leanne Guy added a comment - - edited

          I'd prefer to remove "old' and "new" and then use latex to denote each (a) and (b) with the descriptions you suggest above.
          (I understand these titles OK in internal team meetings, but not in a report.)

          Show
          lguy Leanne Guy added a comment - - edited I'd prefer to remove "old' and "new" and then use latex to denote each (a) and (b) with the descriptions you suggest above. (I understand these titles OK in internal team meetings, but not in a report.)
          Hide
          lauren Lauren MacArthur added a comment -

          I've attached two new versions of each (one with updated titles, one with no titles).  Pick and choose at your pleasure!

          Show
          lauren Lauren MacArthur added a comment - I've attached two new versions of each (one with updated titles, one with no titles).  Pick and choose at your pleasure!
          Hide
          lguy Leanne Guy added a comment -

          Thanks Lauren MacArthur I am happy with any of the alternatives. I'll let Robert Gruendl choose.

          Show
          lguy Leanne Guy added a comment - Thanks Lauren MacArthur I am happy with any of the alternatives. I'll let Robert Gruendl choose.
          Hide
          gruendl Robert Gruendl added a comment -

          Spent time to look at comments and history then read DMTN-159 through once more and think everything has been updated as requested.  

          Show
          gruendl Robert Gruendl added a comment - Spent time to look at comments and history then read DMTN-159 through once more and think everything has been updated as requested.  

            People

            Assignee:
            gruendl Robert Gruendl
            Reporter:
            swinbank John Swinbank
            Reviewers:
            John Swinbank, Leanne Guy
            Watchers:
            Jeffrey Carlin, John Swinbank, Lauren MacArthur, Leanne Guy, Robert Gruendl
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Due:
              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.