Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17125

Complete Milestone LDM-503-11a (ComCam ops readiness)

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Team:
      Data Facility

      Attachments

        Issue Links

          Activity

          Hide
          gruendl Robert Gruendl [X] (Inactive) added a comment -

          Test plan under LVV-P76 has been executed resulting in DMTR-231 being ready for review.

           

          Show
          gruendl Robert Gruendl [X] (Inactive) added a comment - Test plan under LVV-P76 has been executed resulting in DMTR-231 being ready for review.  
          Show
          gcomoretto Gabriele Comoretto [X] (Inactive) added a comment - PR to add comments: https://github.com/lsst-dm/DMTR-231/pull/3
          Hide
          lguy Leanne Guy added a comment - - edited

          Major comments

          • The report uses the phrase "at the current USDF (NCSA)" throughout. USDF is used to describe the operations era data facility, which we now know to be SLAC. This should just be "NCSA" – please change all usages throughout the docucment.
          • LSP is used in many places throughout the document. Change to Rubin Science Platform – RSP.
          • 5.1.1 Software Version/Baseline : Not provided.
            Why not? Can we add the version of the science pipelines that was used to process the data to build the calibration data products.
          • P7 Ste1, Actual Result. The SQL statement is malformed. The correct query is
            select expId,dayObs,imageType,raftName,detectorName from raw where dayObs='2020-07-27';
          • P8 step 2: I know it is example code, but to be consistent with previous statements : setenv REPODIR=/project/shared/comCam (not projects)
          • P8 Step 2: constructBias.py is part of the LSST science pipelines There should be a step in the test script to first set up the LSST science pipelines environment in which to run constructBias.py

          Minor comments

          • P2 ... information about the test plan, like for example the configuration used for this test or related documentation.
          • => such as the configuration used .... (example not a comparison)
          • P6: "test stand capable of delivering image to USDF." => test stand capable of delivering* images to NCSA.*
          • P10 Step 1 "new data were generated toady (2020-10-28)" => today

          There are some minor comments on the PR as well

          Show
          lguy Leanne Guy added a comment - - edited Major comments The report uses the phrase "at the current USDF (NCSA)" throughout. USDF is used to describe the operations era data facility, which we now know to be SLAC. This should just be "NCSA" – please change all usages throughout the docucment. LSP is used in many places throughout the document. Change to Rubin Science Platform – RSP. 5.1.1 Software Version/Baseline : Not provided. Why not? Can we add the version of the science pipelines that was used to process the data to build the calibration data products. P7 Ste1, Actual Result. The SQL statement is malformed. The correct query is select expId,dayObs,imageType,raftName,detectorName from raw where dayObs='2020-07-27'; P8 step 2: I know it is example code, but to be consistent with previous statements : setenv REPODIR= /project/shared/comCam (not projects) P8 Step 2: constructBias.py is part of the LSST science pipelines There should be a step in the test script to first set up the LSST science pipelines environment in which to run constructBias.py Minor comments P2 ... information about the test plan, like for example the configuration used for this test or related documentation. => such as the configuration used .... (example not a comparison) P6: "test stand capable of delivering image to USDF." => test stand capable of delivering* images to NCSA.* P10 Step 1 "new data were generated toady (2020-10-28)" => today There are some minor comments on the PR as well
          Hide
          gruendl Robert Gruendl [X] (Inactive) added a comment -

          Have addressed all comments above (and within PR).  I will let DMTR-231 regenerate over night, scan it to make sure they all worked (and none were missed). 

           

          Show
          gruendl Robert Gruendl [X] (Inactive) added a comment - Have addressed all comments above (and within PR).  I will let DMTR-231 regenerate over night, scan it to make sure they all worked (and none were missed).   

            People

            Assignee:
            gruendl Robert Gruendl [X] (Inactive)
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Leanne Guy
            Watchers:
            Gabriele Comoretto [X] (Inactive), Leanne Guy, Robert Gruendl [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Due:
              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.