Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17217

TAP Search: Improve the constraints table for TAP search

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Firefly
    • Labels:
    • Story Points:
      14
    • Sprint:
      SUIT Sprint 2019-02
    • Team:
      Science User Interface

      Description

      02/28/2019

      1. Implemented support for preserving selections in client tables.
      2. Enabled sorting and filtering of the constraints table itself.
      3. Sorting and filtering does not change checkbox states.
      4. Principal columns are pre-selected.
      5. No switch between All/Principal, removed by Gregory Dubois-Felsmann request.
      6. Removed additional constraints. (They can be added in ADQL tab.)

      Bug fixes:

      1. Now supporting table ids with . character. (UI state was not stored correctly for such tables.)
      2. Enum filter was not shown (hidden behind) when the table is in the dropdown.
      3. It was not possible to request to show filters without showing filter button.
      4. Filter was not working for multi-line values.

      01/14/2019

      (The "constraints table" is the "table of columns" that exposes the schema for a single table and allows a form-based interface for applying per-column constraints to the search being constructed. In the current Gator, IRSA Viewer, and Firefly TAP Search layouts, the "constraints table" is found in the lower half of the screen.)

      The details of what to do need some work.

      Bugs:

      1. The constraints currently don't seem to work / don't appear in the generated ADQL.
      2. The "additional constraints" box at the bottom has a label that mentions "SQL" - should be "ADQL".

      Features:

      1. If the principal column is present in the TAP_SCHEMA.columns data for the table, AND if any row (representing a column in the table being described) has a non-zero value for principal, offer a choice at the top of the displayed table of checkbox-selecting only the "principal non-zero" rows, or all of them. This should offer equivalent functionality to the comparable feature in the IRSA Viewer interface.
      2. Enable sorting and filtering of the constraints table itself.
      3. Ensure that sorting and filtering does not change checkbox states. (Understood that this may need to be handled later.)
      4. Allow the "additional constraints" text to begin with WHERE (or not) as a convenience to the user.

      (review of the current prototype is still ongoing)

        Attachments

          Issue Links

            Activity

            Hide
            gpdf Gregory Dubois-Felsmann added a comment - - edited

            Regarding enabling table filtering on the table-of-columns-and-constraints table in the bottom half of the UI, there are two interesting use cases which should be supported:

            1. Filtering the table on only those rows which have the checkbox set, i.e., showing only the set of columns in the table to be queried whose values will be returned from the query once it's submitted (a/k/a the columns to be enumerated in the SELECT clause of the query). Once the standard Firefly table filtering is enabled, I believe this will be possible with a single mouse click.
            2. Filtering the table on only those rows for which the "constraints" column is non-empty; this is a quick way to show only the constraints to be applied in the WHERE clause. Using this will be a lot less obvious to the users: they'll have to write something like IS NOT "" - but I don't know if that will really work. Can we make this easier for them, both in the filtering language and, perhaps, even with a dedicated UI element?
            Show
            gpdf Gregory Dubois-Felsmann added a comment - - edited Regarding enabling table filtering on the table-of-columns-and-constraints table in the bottom half of the UI, there are two interesting use cases which should be supported: Filtering the table on only those rows which have the checkbox set, i.e., showing only the set of columns in the table to be queried whose values will be returned from the query once it's submitted (a/k/a the columns to be enumerated in the SELECT clause of the query). Once the standard Firefly table filtering is enabled, I believe this will be possible with a single mouse click. Filtering the table on only those rows for which the "constraints" column is non-empty; this is a quick way to show only the constraints to be applied in the WHERE clause. Using this will be a lot less obvious to the users: they'll have to write something like IS NOT "" - but I don't know if that will really work. Can we make this easier for them, both in the filtering language and, perhaps, even with a dedicated UI element?
            Hide
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            Changed the SP number because of scope increase (added a few bug fixes in the iteration)

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Changed the SP number because of scope increase (added a few bug fixes in the iteration)

              People

              • Assignee:
                tatianag Tatiana Goldina
                Reporter:
                roby Trey Roby
                Reviewers:
                Loi Ly
                Watchers:
                Cindy Wang [X] (Inactive), Emmanuel Joliet, Gregory Dubois-Felsmann, Loi Ly, Tatiana Goldina, Trey Roby, Xiuqin Wu [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel