Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17227

Update ATMCS interface

    Details

      Description

      Update ATMCS interface according to discussion with Patrick, Rolando and Russell

      Changes:

      • Add M3 motor encoder data to existing telemetry topics.
      • Remove ATMountState enumeration values that overlap summary state.
      • Remove M3State enumeration values that overlap summary state.
      • Reorder fields in the mountEncoders telemetry topic to the standard order used everywhere else.
      • Rename command topic fields that are ignored to ignored.
      • Rename brake fields from engage to engaged.
      • Remove m3RotatorDetentLimitSwitch to m3RotatorDetentSwitches and remove Detent from the field names.
      • Remove redundant State suffix from ATMountState_ and M3State_ events, e.g. change M3State_DisabledState to M3State_Disabled.
      • Add documentation for all topics (and fix existing incorrect documentation).

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Merged to develop

            Show
            rowen Russell Owen added a comment - Merged to develop
            Hide
            tribeiro Tiago Ribeiro added a comment -

            Changes looks ok. 

            Show
            tribeiro Tiago Ribeiro added a comment - Changes looks ok. 
            Hide
            rowen Russell Owen added a comment - - edited

            I'm taking this on for Andres Anania [X] as he is on family leave. (Andres Anania [X] if you still want it feel free to take it back.)

            Here is the pull request using branch tickets/DM-17227: https://github.com/lsst-ts/ts_xml/pull/63

            Show
            rowen Russell Owen added a comment - - edited I'm taking this on for Andres Anania [X] as he is on family leave. ( Andres Anania [X] if you still want it feel free to take it back.) Here is the pull request using branch tickets/ DM-17227 : https://github.com/lsst-ts/ts_xml/pull/63
            Hide
            aanania Andres Anania [X] (Inactive) added a comment -

            Added preview of the updates to:

            https://github.com/lsst-ts/ts_xml/tree/feature/tickets/DM-17227

            Still need to validate some points 

            Show
            aanania Andres Anania [X] (Inactive) added a comment - Added preview of the updates to: https://github.com/lsst-ts/ts_xml/tree/feature/tickets/DM-17227 Still need to validate some points 
            Hide
            aanania Andres Anania [X] (Inactive) added a comment -

            This task was not needed so I'm re-purposing it

            Show
            aanania Andres Anania [X] (Inactive) added a comment - This task was not needed so I'm re-purposing it

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                aanania Andres Anania [X] (Inactive)
                Reviewers:
                Tiago Ribeiro
                Watchers:
                Andres Anania [X] (Inactive), Patrick Ingraham, Rolando Cantarutti, Russell Owen, Tiago Ribeiro
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Start date:
                  End date:

                  Summary Panel