Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_auxiliary_telescope
-
Story Points:2
-
Sprint:TSSW Sprint - Feb 04 - Feb 16
-
Team:Telescope and Site
Description
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes:
- Add M3 motor encoder data to existing telemetry topics.
- Remove ATMountState enumeration values that overlap summary state.
- Remove M3State enumeration values that overlap summary state.
- Reorder fields in the mountEncoders telemetry topic to the standard order used everywhere else.
- Rename command topic fields that are ignored to ignored.
- Rename brake fields from engage to engaged.
- Remove m3RotatorDetentLimitSwitch to m3RotatorDetentSwitches and remove Detent from the field names.
- Remove redundant State suffix from ATMountState_ and M3State_ events, e.g. change M3State_DisabledState to M3State_Disabled.
- Add documentation for all topics (and fix existing incorrect documentation).
Attachments
Issue Links
- blocks
-
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Sprint | TSSW Sprint - Jan 21 - Feb 02 [ 844 ] |
| Team | Telescope and Site [ 13500 ] |
| Component/s | ts_auxiliary_telescope [ 16708 ] |
| Labels | ATHexapod auxtel |
| Epic Link |
|
| Summary | Remove configuration commands in ATHexapod if apply | Update ATMCS interface |
| Description |
Review these points with Patrick and check if apply, if so implement.
* *applyPositionLimits*: Set the limit for the positions (Also set in the configuration file): ** Why not only in configuration file?. *** Currently this has been copied from the main telescope Hexapod interface but it does make sense to leave these to the configuration files only. * *pivot command:* ** What happens if this condition is not met? This check should occur before enabling the command on the GUI, and upon receipt, in the controller. ** Why not only in configuration file? |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell |
| Watchers | Andres Anania, Patrick Ingraham, Paul Lotz [ Andres Anania, Patrick Ingraham, Paul Lotz ] | Andres Anania, Patrick Ingraham, Rolando Cantarutti, Russell Owen [ Andres Anania, Patrick Ingraham, Rolando Cantarutti, Russell Owen ] |
| Labels | ATHexapod auxtel | atmcs auxtel |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Russell Owen [ rowen ] |
Added preview of the updates to:
https://github.com/lsst-ts/ts_xml/tree/feature/tickets/DM-17227
Still need to validate some points
| Assignee | Andres Anania [ aanania ] | Russell Owen [ rowen ] |
| Story Points | 1 | 2 |
I'm taking this on for Andres Anania [X] as he is on family leave. (Andres Anania [X] if you still want it feel free to take it back.)
Here is the pull request using branch tickets/DM-17227: https://github.com/lsst-ts/ts_xml/pull/63
| Description | Update ATMCS interface according to discussion with Patrick, Rolando and Russell |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Non-backward compatible changes: - Add M3 motor encoder data to existing telemetry topics. - Remote ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. Backward-compatible changes: - Rename command topic fields that are ignored to {{ignored}}. - Add documentation for all topics (and fix existing incorrect documentation). |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Non-backward compatible changes: - Add M3 motor encoder data to existing telemetry topics. - Remote ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. Backward-compatible changes: - Rename command topic fields that are ignored to {{ignored}}. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remote ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Add documentation for all topics (and fix existing incorrect documentation). |
| Issue Type | Improvement [ 4 ] | Story [ 10001 ] |
| Sprint | TSSW Sprint - Jan 21 - Feb 02 [ 844 ] | TSSW Sprint - Feb 04 - Feb 16 [ 845 ] |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remote ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Add documentation for all topics (and fix existing incorrect documentation). |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{enable}} to {{enabled}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitch}} and remove {{Detent}} from the field names. - Add documentation for all topics (and fix existing incorrect documentation). |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{enable}} to {{enabled}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitch}} and remove {{Detent}} from the field names. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{enable}} to {{enabled}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Add documentation for all topics (and fix existing incorrect documentation). |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{enable}} to {{enabled}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{enable}} to {{enabled}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}. - Add documentation for all topics (and fix existing incorrect documentation). |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{enable}} to {{enabled}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{engage}} to {{engaged}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}. - Add documentation for all topics (and fix existing incorrect documentation). |
| Link | This issue relates to TPC-118 [ TPC-118 ] |
| Reviewers | Russell Owen [ rowen ] | Tiago Ribeiro [ tribeiro ] |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Description |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{engage}} to {{engaged}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}. - Add documentation for all topics (and fix existing incorrect documentation). |
Update ATMCS interface according to discussion with Patrick, Rolando and Russell
Changes: - Add M3 motor encoder data to existing telemetry topics. - Remove ATMountState enumeration values that overlap summary state. - Remove M3State enumeration values that overlap summary state. - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else. - Rename command topic fields that are ignored to {{ignored}}. - Rename brake fields from {{engage}} to {{engaged}}. - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names. - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}. - Add documentation for all topics (and fix existing incorrect documentation). |
Changes looks ok.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Merged to develop
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| End date | 13/Feb/19 | |
| Start date | 15/Jan/19 |
This task was not needed so I'm re-purposing it