Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17227

Update ATMCS interface

    Details

      Description

      Update ATMCS interface according to discussion with Patrick, Rolando and Russell

      Changes:

      • Add M3 motor encoder data to existing telemetry topics.
      • Remove ATMountState enumeration values that overlap summary state.
      • Remove M3State enumeration values that overlap summary state.
      • Reorder fields in the mountEncoders telemetry topic to the standard order used everywhere else.
      • Rename command topic fields that are ignored to ignored.
      • Rename brake fields from engage to engaged.
      • Remove m3RotatorDetentLimitSwitch to m3RotatorDetentSwitches and remove Detent from the field names.
      • Remove redundant State suffix from ATMountState_ and M3State_ events, e.g. change M3State_DisabledState to M3State_Disabled.
      • Add documentation for all topics (and fix existing incorrect documentation).

        Attachments

          Issue Links

            Activity

            aanania Andres Anania [X] (Inactive) created issue -
            aanania Andres Anania [X] (Inactive) made changes -
            Field Original Value New Value
            Sprint TSSW Sprint - Jan 21 - Feb 02 [ 844 ]
            swinbank John Swinbank made changes -
            Team Telescope and Site [ 13500 ]
            jbuffill James Buffill [X] (Inactive) made changes -
            Component/s ts_auxiliary_telescope [ 16708 ]
            jbuffill James Buffill [X] (Inactive) made changes -
            Labels ATHexapod auxtel
            jbuffill James Buffill [X] (Inactive) made changes -
            Epic Link DM-16912 [ 238243 ]
            aanania Andres Anania [X] (Inactive) made changes -
            Epic Link DM-16912 [ 238243 ] DM-16913 [ 238244 ]
            aanania Andres Anania [X] (Inactive) made changes -
            Summary Remove configuration commands in ATHexapod if apply Update ATMCS interface
            aanania Andres Anania [X] (Inactive) made changes -
            Description Review these points with Patrick and check if apply, if so implement.
             * *applyPositionLimits*: Set the limit for the positions (Also set in the configuration file):
             ** Why not only in configuration file?.
             *** Currently this has been copied from the main telescope Hexapod interface but it does make sense to leave these to the configuration files only.
             * *pivot command:*
             ** What happens if this condition is not met?
            This check should occur before enabling the command on the GUI, and upon receipt, in the controller.
             ** Why not only in configuration file?
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell
            aanania Andres Anania [X] (Inactive) made changes -
            Watchers Andres Anania, Patrick Ingraham, Paul Lotz [ Andres Anania, Patrick Ingraham, Paul Lotz ] Andres Anania, Patrick Ingraham, Rolando Cantarutti, Russell Owen [ Andres Anania, Patrick Ingraham, Rolando Cantarutti, Russell Owen ]
            aanania Andres Anania [X] (Inactive) made changes -
            Labels ATHexapod auxtel atmcs auxtel
            aanania Andres Anania [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            rowen Russell Owen made changes -
            Link This issue blocks DM-17511 [ DM-17511 ]
            aanania Andres Anania [X] (Inactive) made changes -
            Reviewers Russell Owen [ rowen ]
            rowen Russell Owen made changes -
            Assignee Andres Anania [ aanania ] Russell Owen [ rowen ]
            rowen Russell Owen made changes -
            Story Points 1 2
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Non-backward compatible changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remote ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.

            Backward-compatible changes:
            - Rename command topic fields that are ignored to {{ignored}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Non-backward compatible changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remote ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.

            Backward-compatible changes:
            - Rename command topic fields that are ignored to {{ignored}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remote ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            jbuffill James Buffill [X] (Inactive) made changes -
            Issue Type Improvement [ 4 ] Story [ 10001 ]
            jbuffill James Buffill [X] (Inactive) made changes -
            Sprint TSSW Sprint - Jan 21 - Feb 02 [ 844 ] TSSW Sprint - Feb 04 - Feb 16 [ 845 ]
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remote ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{enable}} to {{enabled}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitch}} and remove {{Detent}} from the field names.
            - Add documentation for all topics (and fix existing incorrect documentation).
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{enable}} to {{enabled}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitch}} and remove {{Detent}} from the field names.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{enable}} to {{enabled}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Add documentation for all topics (and fix existing incorrect documentation).
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{enable}} to {{enabled}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{enable}} to {{enabled}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{enable}} to {{enabled}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{engage}} to {{engaged}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            tribeiro Tiago Ribeiro made changes -
            Link This issue relates to TPC-118 [ TPC-118 ]
            rowen Russell Owen made changes -
            Reviewers Russell Owen [ rowen ] Tiago Ribeiro [ tribeiro ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            rowen Russell Owen made changes -
            Description Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{engage}} to {{engaged}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            Update ATMCS interface according to discussion with Patrick, Rolando and Russell

            Changes:
            - Add M3 motor encoder data to existing telemetry topics.
            - Remove ATMountState enumeration values that overlap summary state.
            - Remove M3State enumeration values that overlap summary state.
            - Reorder fields in the {{mountEncoders}} telemetry topic to the standard order used everywhere else.
            - Rename command topic fields that are ignored to {{ignored}}.
            - Rename brake fields from {{engage}} to {{engaged}}.
            - Remove {{m3RotatorDetentLimitSwitch}} to {{m3RotatorDetentSwitches}} and remove {{Detent}} from the field names.
            - Remove redundant {{State}} suffix from {{ATMountState_}} and {{M3State_}} events, e.g. change {{M3State_DisabledState}} to {{M3State_Disabled}}.
            - Add documentation for all topics (and fix existing incorrect documentation).
            tribeiro Tiago Ribeiro made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            jbuffill James Buffill [X] (Inactive) made changes -
            End date 13/Feb/19
            Start date 15/Jan/19

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                aanania Andres Anania [X] (Inactive)
                Reviewers:
                Tiago Ribeiro
                Watchers:
                Andres Anania [X] (Inactive), Patrick Ingraham, Rolando Cantarutti, Russell Owen, Tiago Ribeiro
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Start date:
                  End date:

                  Summary Panel