Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17248

ap_verify should create .json files in the workspace by default

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP S19-3, AP S19-4
    • Team:
      Alert Production

      Description

      Currently, ap_verify creates its metrics files in the caller's working directory. A more compartmentalized way to handle the output is to put it in the workspace created with the --output command-line argument. This will not interfere with the Butler (since the workspace is not a repository) or CI upload (which searches for files in the entire directory tree, see DM-16728).

      The main complication is how to handle the --metrics-file argument. The best option is probably to include an {output} placeholder (making the default value "{output}ap_verify.{dataId}.verify.json"). This will avoid surprising behavior from making the directory implicit, and will be backwards-compatible with any scripts that already use --metrics-file.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Hi Meredith Rawls, could you review this ticket? Thanks!

            Show
            krzys Krzysztof Findeisen added a comment - Hi Meredith Rawls , could you review this ticket? Thanks!
            Hide
            mrawls Meredith Rawls added a comment -

            This looks good, thank you for implementing it! I asked a clarifying question over on GitHub but that shouldn't prevent you from merging.

            Show
            mrawls Meredith Rawls added a comment - This looks good, thank you for implementing it! I asked a clarifying question over on GitHub but that shouldn't prevent you from merging.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Meredith Rawls
              Watchers:
              Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.