Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:5
-
Epic Link:
-
Sprint:TSSW Sprint - Jan 21 - Feb 01, TSSW Sprint - Mar 30 - Apr 13
-
Team:Telescope and Site
Description
Once the software is officially delivered to LSST, it will be necessary to update the design and code to conform to SAL constraints and conventions, as defined in https://confluence.lsstcorp.org/display/SYSENG/SAL+constraints+and+recommendations
This includes:
- Naming conventions
- Enumeration definition
- Implementation of all standard commands and events.
Attachments
Activity
1) Completed, we have discussed and Russell myself and alberto can work on the XML with no issue because Russell works on "NewMTMount" subsystem while the work Alberto and myself will do is on "MTMount" and therefore not effecting each others work.
2) Russell and Alberto have discussed the telemetry topics which are to become events.
3) same as 2
4) In order to do this testing we need ethernet cards which I have made a requisition for.
Also meeting on this Friday April 6 to complete any issues with the MTMount xml.
If the XML tests pass we are all good. Do not merge into develop please. (edit) the test which now passes that did not previously is test_AttributeNaming.py. This test should be passing. I will need to make other tasks in the future to fix the others.
I will need to revisit this to resolve tests which are currently being skipped.
- test_TopicNaming.py
- test_NoReservedWords.py
For now I need to continue onto other work.
Tasks tracked here DM-24358
The issue in the MTMount XMLs in regards to the test_AttributeNaming.py unit test have been resolved. The work for the remaining issues will be tracked using the linked ticket. Then all fixes will be merged to develop.
I replicated the issue,
To resolve this the first step I will make is getting in contact with Tekniker.
I could simply fix the topics however this wouldn't really resolve anything since the software using the topics won't be updated. Therefor for actual resolution of the telemetry file the following steps will be taken.
1) Meeting with Alberto and Russell discuss the updates of the Telemetry topics
2) There are a few that Russell and myself already discussed that we prefer become events
3) The Topics that we decide to keep as Telemetry update them in the labview software and update in the XML
4) Test the software with the TMA simulator to exercise the publishing of the telemetry topics.