Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17284

Add ctrl_mpexec to lsst_distrib

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Epic Link:
    • Sprint:
      BG3_S19_01
    • Team:
      Data Access and Database

      Description

      Last item for RFC-554 is to add new re-factored package to lsst_distrib.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17038 Re-factoring of ctrl_mpexec

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-554 Refactoring of pipe_supertask

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            salnikov Andy Salnikov created issue -
            salnikov Andy Salnikov made changes -
            Field Original Value New Value
            Epic Link DM-16793 [ 236151 ]
            salnikov Andy Salnikov made changes -
            Link This issue is triggered by RFC-554 [ RFC-554 ]
            salnikov Andy Salnikov made changes -
            Link This issue is blocked by DM-17038 [ DM-17038 ]
            salnikov Andy Salnikov made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            salnikov Andy Salnikov made changes -
            Watchers Andy Salnikov [ Andy Salnikov ] Andy Salnikov, Vaikunth Thukral [ Andy Salnikov, Vaikunth Thukral ]
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Tim Jenness, can you review lsst_distrib PR? I merged repos already as I figured out it has to be in the master before Jenkins start. Jenkins currently runs the build (https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29281/pipeline) and I wait to merge until it completes. It has built ctrl_mpexec already so I'm confident things should work OK (and nothing else depends on ctrl_mpexec, this is why it ended up at top level lsst_distrib table).

            Show
            salnikov Andy Salnikov added a comment - Tim Jenness , can you review lsst_distrib  PR? I merged repos already as I figured out it has to be in the master before Jenkins start. Jenkins currently runs the build ( https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29281/pipeline)  and I wait to merge until it completes. It has built ctrl_mpexec already so I'm confident things should work OK (and nothing else depends on ctrl_mpexec, this is why it ended up at top level lsst_distrib table).
            salnikov Andy Salnikov made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks fine to me. Yes, repos can be self merged so long as the travis checks pass.

            Show
            tjenness Tim Jenness added a comment - Looks fine to me. Yes, repos can be self merged so long as the travis checks pass.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Thanks! 

            repos can be self merged so long as the travis checks pass

            Took me a bit of effort to realize as documentation says that "[repos] will be checked by the stack-os-matrix Jenkins job" (not Travis).

            Show
            salnikov Andy Salnikov added a comment - Thanks!  repos can be self merged so long as the travis checks pass Took me a bit of effort to realize as documentation says that " [repos] will be checked by the stack-os-matrix Jenkins job" (not Travis).
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Which documentation is wrong? cc/ Joshua Hoblitt

            Show
            tjenness Tim Jenness added a comment - Which documentation is wrong? cc/ Joshua Hoblitt
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            https://developer.lsst.io/stack/adding-a-new-package.html#adding-a-new-package-to-the-build

            Show
            salnikov Andy Salnikov added a comment - https://developer.lsst.io/stack/adding-a-new-package.html#adding-a-new-package-to-the-build
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            centos6/7 builds finished OK, osx will probably take another day so I'm going to declare it a success and merge.

            Show
            salnikov Andy Salnikov added a comment - centos6/7 builds finished OK, osx will probably take another day so I'm going to declare it a success and merge.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Merged and done. Nothing is going to break because it's Friday 

            Show
            salnikov Andy Salnikov added a comment - Merged and done. Nothing is going to break because it's Friday 
            salnikov Andy Salnikov made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Tim Jenness
              Watchers:
              Andy Salnikov, Tim Jenness, Vaikunth Thukral
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.