Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17292

Add obs_lsst camera package unit tests

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base, obs_lsst
    • Labels:
      None

      Description

      Several functions in obs_lsst and obs_base are doing complicated math and list processing, and they should have unit tests (even if the functions are perfect, it's extremely difficult to understand what they're doing). In LsstCamMapper  _computeCoaddExposureId() and query_raw_amp() need specific tests, as does the inner loop in assemble_raw. In obs_base, YamlCamera needs tests.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Simon Krughoff can you review this? Test coverage is now at 93% with the mappers being significantly higher than that. I've cleaned up a lot of the code as well based on the testing.

            Show
            tjenness Tim Jenness added a comment - Simon Krughoff can you review this? Test coverage is now at 93% with the mappers being significantly higher than that. I've cleaned up a lot of the code as well based on the testing.
            Hide
            krughoff Simon Krughoff added a comment -

            I have a few trivial comments on the PR.

            Show
            krughoff Simon Krughoff added a comment - I have a few trivial comments on the PR.
            Hide
            tjenness Tim Jenness added a comment -

            Branch merged.

            Show
            tjenness Tim Jenness added a comment - Branch merged.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                womullan Wil O'Mullane
                Reviewers:
                Simon Krughoff
                Watchers:
                Colin Slater, John Swinbank, Leanne Guy, Robert Lupton, Simon Krughoff, Tim Jenness, Wil O'Mullane
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel