Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17297

Remove CatalogStarSelector

    XMLWordPrintable

    Details

      Description

      Implement the adopted change of RFC-560, removing the unused CatalogStarSlectorTask

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-560 Remove CatalogStarSelectorTask

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29260/pipeline

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29260/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            A bulk search for `catalogStar` turns up a mention in a docstring for pipe_tasks/processCcd.py and an if statement in ip_diffim/diaCatalogSourceSelector.py that should both be cleaned up. I think that's it?

            Show
            Parejkoj John Parejko added a comment - A bulk search for `catalogStar` turns up a mention in a docstring for pipe_tasks/processCcd.py and an if statement in ip_diffim/diaCatalogSourceSelector.py that should both be cleaned up. I think that's it?
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the removals. Please file that RFC to cleanup this interface to processCcd.

            Show
            Parejkoj John Parejko added a comment - Thanks for the removals. Please file that RFC to cleanup this interface to processCcd.
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Final Jenkins just in case: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29272/pipeline/46/

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Final Jenkins just in case: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29272/pipeline/46/
            Hide
            Permalink
            cmorrison Chris Morrison [X] (Inactive) added a comment -

            Considering my lack of familiarity with that particular code path or even why it was there in the first place, I will let someone else file the RFC Jim Bosch

            Show
            cmorrison Chris Morrison [X] (Inactive) added a comment - Considering my lack of familiarity with that particular code path or even why it was there in the first place, I will let someone else file the RFC Jim Bosch
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I may not do it immediately, but I will be looking at that code next week anyway and that should give me an opportunity to say more precisely what we'd want to do.

            Show
            jbosch Jim Bosch added a comment - I may not do it immediately, but I will be looking at that code next week anyway and that should give me an opportunity to say more precisely what we'd want to do.

              People

              Assignee:
              cmorrison Chris Morrison [X] (Inactive)
              Reporter:
              cmorrison Chris Morrison [X] (Inactive)
              Reviewers:
              John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.