Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17299

Clean up obs_lsst scripts

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None

      Description

      Test scripts in bin/ need to either go elsewhere or have names that are more clear. They'll get loaded into the default search path and nobody will know why processCcd does something totally different than processCcd.py.

      In the Python library directory, the files segmentationToRafts.py and phosimToRafts.py, generateCamera.py are more like scripts, belong elsewhere (e.g. in bin/). They have  {__main__}} blocks and they do not look like they are meant to get imported by anything else so there is no reason to have them in the module.

      These issues should be addressed before inclusion in lsst_distrib.

        Attachments

          Issue Links

            Activity

            Hide
            krughoff Simon Krughoff added a comment -

            Wil O'Mullane I'm assigning this to me, but if you have another victim in mind, let me know.

            Show
            krughoff Simon Krughoff added a comment - Wil O'Mullane I'm assigning this to me, but if you have another victim in mind, let me know.
            Hide
            krughoff Simon Krughoff added a comment -

            This is largely moving things around, though I did add a test for one of the scripts. I also converted from .format to f-strings in one of the scripts.

            Show
            krughoff Simon Krughoff added a comment - This is largely moving things around, though I did add a test for one of the scripts. I also converted from .format to f-strings in one of the scripts.
            Hide
            tjenness Tim Jenness added a comment -

            Some good changes here. Thanks. Minor cleanups requested.

            Show
            tjenness Tim Jenness added a comment - Some good changes here. Thanks. Minor cleanups requested.
            Hide
            krughoff Simon Krughoff added a comment -

            Merged.

            Show
            krughoff Simon Krughoff added a comment - Merged.
            Hide
            krughoff Simon Krughoff added a comment -

            I'm reopening since I completely neglected to respond to Tim Jenness's comment on ci_lsst.

            Show
            krughoff Simon Krughoff added a comment - I'm reopening since I completely neglected to respond to Tim Jenness 's comment on ci_lsst .
            Hide
            tjenness Tim Jenness added a comment -

            Thanks. Looks okay. I have a minor quibble that command line programs tend to be underscore rather than camel-case and ingest_ci_lsst is cleaner to me and easier to type than ingest_CiLsst (I even had to pause and think as I wrote that).

            Show
            tjenness Tim Jenness added a comment - Thanks. Looks okay. I have a minor quibble that command line programs tend to be underscore rather than camel-case and ingest_ci_lsst is cleaner to me and easier to type than ingest_CiLsst (I even had to pause and think as I wrote that).
            Hide
            krughoff Simon Krughoff added a comment -

            Scripts renamed and merged.

            Show
            krughoff Simon Krughoff added a comment - Scripts renamed and merged.

              People

              • Assignee:
                krughoff Simon Krughoff
                Reporter:
                womullan Wil O'Mullane
                Reviewers:
                Tim Jenness
                Watchers:
                Colin Slater, Heather Kelly, John Swinbank, Leanne Guy, Robert Lupton, Simon Krughoff, Tim Jenness, Wil O'Mullane
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel