Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17310

Complete implementation of basic functionality of TunableLaser CSC

    Details

      Description

      Technically the code is there, but has not been functionally tested. In order to be complete, it must be tested and working. This allows the TunableLaser to start emitting the light beam and stop emitting through SAL state transitions. The component API already implements this functionality. Had Russell Owen look over the current implementation and he had some suggestions. I will be making those changes as part of this task.

      The CSC now demonstrates basic state transitions including substates for propagating the laser. It demonstrates both local host functionality and network functionality with the chesterfield script machine. It can start propagating when in the enabled state. It can also stop propagating and be in the enabled state or if disabled will also stop propagating. Revamped the hardware wrapper api based on better understanding of hardware itself, updated the firmware to gain access to several error registers. Revamped unit tests to a slight degree. There is also a very simple settings api. Added all temperature sensors to telemetry in preparation for some stability(plus the fact that we don't know which ones are important). Added changedWavelength event to indicate that the wavelength has changed(may be redundant if wavelength is published as telemetry). 

       

      Github Pull Request

        Attachments

          Activity

          Hide
          ecoughlin Eric Coughlin added a comment -
          Show
          ecoughlin Eric Coughlin added a comment - Github Pull Request
          Hide
          tribeiro Tiago Ribeiro added a comment -

          Code review done on GitHub. After talking to Eric Coughlin in private we decided that the remaining issues raised during the code review will be handled in a separate task. I'll write the tickets to capture them and they will be prioritized as needed. I'll approve the PR and close the Code review as they achieve the intended goals of this ticket.

          Show
          tribeiro Tiago Ribeiro added a comment - Code review done on GitHub. After talking to Eric Coughlin in private we decided that the remaining issues raised during the code review will be handled in a separate task. I'll write the tickets to capture them and they will be prioritized as needed. I'll approve the PR and close the Code review as they achieve the intended goals of this ticket.
          Hide
          ecoughlin Eric Coughlin added a comment -

          Have merged PR as agreed by reviewer.

          Show
          ecoughlin Eric Coughlin added a comment - Have merged PR as agreed by reviewer.
          Hide
          pingraham Patrick Ingraham added a comment -

          Eric Coughlin, Tiago Ribeiro - Where is the ticket to perform the future work?

          Why was this merged and marked complete without that ticket being filed?

           

           

          Show
          pingraham Patrick Ingraham added a comment - Eric Coughlin , Tiago Ribeiro - Where is the ticket to perform the future work? Why was this merged and marked complete without that ticket being filed?    

            People

            • Assignee:
              ecoughlin Eric Coughlin
              Reporter:
              ecoughlin Eric Coughlin
              Reviewers:
              Tiago Ribeiro
              Watchers:
              Eric Coughlin, Patrick Ingraham, Tiago Ribeiro
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Start date:
                End date:

                Summary Panel