Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17366

Get Pointing Component to build in the TSSW CI

    XMLWordPrintable

    Details

      Description

      Get the Pointing Component tests created and running.  Get the Docker image from Andrés that has the PtgComp installed.  Figure out how to run the vendor supplied Robot-Framework tests.  

        Attachments

          Issue Links

            Activity

            Hide
            rbovill Rob Bovill added a comment -

            I created a Docker image for QA use of building and testing the pointing component.  The Dockerfile may be found at https://github.com/lsst-ts/ts_Dockerfiles currently in the pointing_qa folder on the u/rbovill/robot branch.  The pull request for this is at https://github.com/lsst-ts/ts_Dockerfiles/pull/4

            The Docker image was pushed to lsstts org on DockerHub, https://cloud.docker.com/u/lsstts/repository/docker/lsstts/pointing

            Show
            rbovill Rob Bovill added a comment - I created a Docker image for QA use of building and testing the pointing component.  The Dockerfile may be found at https://github.com/lsst-ts/ts_Dockerfiles currently in the pointing_qa folder on the u/rbovill/robot branch.  The pull request for this is at https://github.com/lsst-ts/ts_Dockerfiles/pull/4 The Docker image was pushed to lsstts org on DockerHub, https://cloud.docker.com/u/lsstts/repository/docker/lsstts/pointing
            Hide
            rbovill Rob Bovill added a comment -

            The Jenkins build is now configured and running.  It is successfully building the PtgControllers.

            https://ts-ci.lsst.codes/job/ts_pointing_common/

            Functional testing of the CSC is still needed.  Work for this is tracked by https://jira.lsstcorp.org/browse/DM-17649

            Show
            rbovill Rob Bovill added a comment - The Jenkins build is now configured and running.  It is successfully building the PtgControllers. https://ts-ci.lsst.codes/job/ts_pointing_common/ Functional testing of the CSC is still needed.  Work for this is tracked by https://jira.lsstcorp.org/browse/DM-17649
            Hide
            rbovill Rob Bovill added a comment -

            Ready for review.

            Show
            rbovill Rob Bovill added a comment - Ready for review.
            Hide
            aheyer Andrew Heyer [X] (Inactive) added a comment -

            Reviewed over the Jenkins builds to confirm runs were being made. 

            Show
            aheyer Andrew Heyer [X] (Inactive) added a comment - Reviewed over the Jenkins builds to confirm runs were being made. 
            Hide
            tribeiro Tiago Ribeiro added a comment -

            So, I was kind intrigued by the fact that this build successfully whereas it fails when I tried to build the exact same version of the software (I checked the commit hash to make sure).

            Looking at the output of the build, I see an error right at the beginning of the build:

             

            In file included from ../src/SAL_Environment.cpp:6:0:
            ../src/SAL_Environment.h:20:20: fatal error: Python.h: No such file or directory
             #include "Python.h"
            

             

            So maybe that explains why it does not get to the point of the build where it reaches the bug in the code. 

             

            https://github.com/lsst-ts/ts_pointing_common/blob/3991d040c546ea382b96c7f46e8ecf6404a41d7d/src/c%2B%2B/kernel/point_file.cpp#L70-L72

             

            Also, is the idea of this task to actually run the tests provided by the vendor?  

            Show
            tribeiro Tiago Ribeiro added a comment - So, I was kind intrigued by the fact that this build successfully whereas it fails when I tried to build the exact same version of the software (I checked the commit hash to make sure). Looking at the output of the build, I see an error right at the beginning of the build:   In file included from .. /src/SAL_Environment .cpp:6:0: .. /src/SAL_Environment .h:20:20: fatal error: Python.h: No such file or directory #include "Python.h"   So maybe that explains why it does not get to the point of the build where it reaches the bug in the code.    https://github.com/lsst-ts/ts_pointing_common/blob/3991d040c546ea382b96c7f46e8ecf6404a41d7d/src/c%2B%2B/kernel/point_file.cpp#L70-L72   Also, is the idea of this task to actually run the tests provided by the vendor?  
            Hide
            rbovill Rob Bovill added a comment -

             Did not have time to get the tests running, but was able to get the code to build in Jenkins.  The work to get the tests running is tracked by DM-17660.

            Show
            rbovill Rob Bovill added a comment -  Did not have time to get the tests running, but was able to get the code to build in Jenkins.  The work to get the tests running is tracked by DM-17660 .
            Hide
            tribeiro Tiago Ribeiro added a comment -

            Verified that the code is building on Jenkins. 

            Show
            tribeiro Tiago Ribeiro added a comment - Verified that the code is building on Jenkins. 

              People

              Assignee:
              rbovill Rob Bovill
              Reporter:
              rbovill Rob Bovill
              Reviewers:
              Tiago Ribeiro
              Watchers:
              Andrew Heyer [X] (Inactive), Rob Bovill, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.