Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_qa
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:TSSW Sprint - Jan 21 - Feb 02
-
Team:Telescope and Site
Description
Get the Pointing Component tests created and running. Get the Docker image from Andrés that has the PtgComp installed. Figure out how to run the vendor supplied Robot-Framework tests.
Attachments
Issue Links
- has to be done before
-
- Done
Activity
| Field | Original Value | New Value |
|---|---|---|
| Component/s | ts_qa [ 16723 ] | |
| Description | Get the Pointing Component tests created and running. Get the Docker image from Andrés that has the PtgComp installed. Figure out how to run the vendor supplied Robot-Framework tests. |
| Story Points | 2 |
| Priority | Undefined [ 10000 ] | Major [ 3 ] |
| Labels | PointingComponent QA |
| Epic Link |
|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
The Jenkins build is now configured and running. It is successfully building the PtgControllers.
https://ts-ci.lsst.codes/job/ts_pointing_common/
Functional testing of the CSC is still needed. Work for this is tracked by https://jira.lsstcorp.org/browse/DM-17649
Ready for review.
| Reviewers | Tiago Ribeiro [ tribeiro ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Reviewed over the Jenkins builds to confirm runs were being made.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Status | Reviewed [ 10101 ] | In Review [ 10004 ] |
So, I was kind intrigued by the fact that this build successfully whereas it fails when I tried to build the exact same version of the software (I checked the commit hash to make sure).
Looking at the output of the build, I see an error right at the beginning of the build:
In file included from ../src/SAL_Environment.cpp:6:0: |
../src/SAL_Environment.h:20:20: fatal error: Python.h: No such file or directory |
#include "Python.h" |
So maybe that explains why it does not get to the point of the build where it reaches the bug in the code.
Also, is the idea of this task to actually run the tests provided by the vendor?
| Summary | Pointing Component testing | Get Pointing Component to build in the TSSW CI |
| Description | Get the Pointing Component tests created and running. Get the Docker image from Andrés that has the PtgComp installed. Figure out how to run the vendor supplied Robot-Framework tests. | Get the Pointing Component tests created and running. Get the Docker image from Andrés that has the PtgComp installed. -Figure out how to run the vendor supplied Robot-Framework tests.- |
Did not have time to get the tests running, but was able to get the code to build in Jenkins. The work to get the tests running is tracked by DM-17660.
Verified that the code is building on Jenkins.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| End date | 04/Feb/19 | |
| Start date | 18/Jan/19 |
I created a Docker image for QA use of building and testing the pointing component. The Dockerfile may be found at https://github.com/lsst-ts/ts_Dockerfiles currently in the pointing_qa folder on the u/rbovill/robot branch. The pull request for this is at https://github.com/lsst-ts/ts_Dockerfiles/pull/4
The Docker image was pushed to lsstts org on DockerHub, https://cloud.docker.com/u/lsstts/repository/docker/lsstts/pointing