Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17375

Change license of astro_metadata_translator

    XMLWordPrintable

Details

    • 2
    • Arch 2019-01-14, Arch 2019-01-21
    • Architecture

    Description

      astro_metadata_translator has by default been using GPLv3. In order to encourage contributions from the astropy community in this ticket we will change the license to BSD 3-clause.

      Attachments

        Activity

          No builds found.
          tjenness Tim Jenness created issue -
          tjenness Tim Jenness made changes -
          Field Original Value New Value
          Component/s astro_metadata_translator [ 15700 ]
          tjenness Tim Jenness added a comment -

          womullan I have made the changes to BSD. I think though that I should make a similar change to the obs_lsst package in the python/lsst/obs/lsst/translators sub directory so that we retain the option of moving that code out of there and into astro_metadata_translator. It will be easier to do that if the license of the subdir is compatible from the beginning (and it's compatible with GPLv3 in obs_lsst if we do this). I can make the change on this ticket as well if you would like. ktl may also have an opinion.

          tjenness Tim Jenness added a comment - womullan I have made the changes to BSD. I think though that I should make a similar change to the obs_lsst package in the python/lsst/obs/lsst/translators sub directory so that we retain the option of moving that code out of there and into astro_metadata_translator . It will be easier to do that if the license of the subdir is compatible from the beginning (and it's compatible with GPLv3 in obs_lsst if we do this). I can make the change on this ticket as well if you would like. ktl may also have an opinion.
          tjenness Tim Jenness made changes -
          Reviewers Wil O'Mullane [ womullan ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          ktl Kian-Tat Lim added a comment -

          Seems to me that it is complex to have a single package with multiple licenses for different directories within it. The number of authors does not seem so high as to prevent getting their approval to relicense if you move the code. Or just go ahead and move the code now.

          ktl Kian-Tat Lim added a comment - Seems to me that it is complex to have a single package with multiple licenses for different directories within it. The number of authors does not seem so high as to prevent getting their approval to relicense if you move the code. Or just go ahead and move the code now.
          tjenness Tim Jenness added a comment -

          Two reasons for not moving the code out of obs_lsst now:

          1. It's changing a lot and I get the feeling that people will be grumpy if they have to make changes in obs_lsst and astro_metadata_translator.
          2. Currently the detector name to detector number mapping requires the camera policy files in obs_lsst. I'm not sure whether it's okay to extract that mapping and keep it separate (or else have astro_metadata_translator try to load obs_lsst if it gets used: which will be a little against the ethos of making it easy for people outside the project to do the translations).

          tjenness Tim Jenness added a comment - Two reasons for not moving the code out of obs_lsst now: 1. It's changing a lot and I get the feeling that people will be grumpy if they have to make changes in obs_lsst and astro_metadata_translator. 2. Currently the detector name to detector number mapping requires the camera policy files in obs_lsst. I'm not sure whether it's okay to extract that mapping and keep it separate (or else have astro_metadata_translator try to load obs_lsst if it gets used: which will be a little against the ethos of making it easy for people outside the project to do the translations).
          swinbank John Swinbank added a comment - - edited

          Presumably you need the approval of copyright holders, rather than authors, to relicense. Those will presumably be the DM institutions, and it seems unlikely to be a major hurdle (Princeton & UW won't care about licensing; I suppose maybe somewhere like SLAC might have institutional policies).

          Tangentially, I note that the code in python/lsst/obs/lsst/translators refers me to “the COPYRIGHT file at the top-level directory of this distribution”, which doesn't seem to exist in obs_lsst. ktl, as I recall you had a script that generated this file automatically — care to do the honours here?

          swinbank John Swinbank added a comment - - edited Presumably you need the approval of copyright holders, rather than authors, to relicense. Those will presumably be the DM institutions, and it seems unlikely to be a major hurdle (Princeton & UW won't care about licensing; I suppose maybe somewhere like SLAC might have institutional policies). Tangentially, I note that the code in python/lsst/obs/lsst/translators refers me to “the COPYRIGHT file at the top-level directory of this distribution”, which doesn't seem to exist in obs_lsst. ktl , as I recall you had a script that generated this file automatically — care to do the honours here?
          tjenness Tim Jenness added a comment -

          The files in that directory were copied from templates in astro_metadata_translator rather than coming from obs_lsst. Most of the code was written by me anyhow (with a bit copied from pre-existing translations from Robert and Merlin). There is no UW code involved.

          tjenness Tim Jenness added a comment - The files in that directory were copied from templates in astro_metadata_translator rather than coming from obs_lsst. Most of the code was written by me anyhow (with a bit copied from pre-existing translations from Robert and Merlin). There is no UW code involved.

          There is no UW code involved.

          Yes, of course — I'm considering a potential future scenario where you want to relicense and the number of contributors has grown. I assume you already have permission to relicense your own work from your employer.

          swinbank John Swinbank added a comment - There is no UW code involved. Yes, of course — I'm considering a potential future scenario where you want to relicense and the number of contributors has grown. I assume you already have permission to relicense your own work from your employer.
          tjenness Tim Jenness added a comment -

          Right. The permission is effectively the same permission that womullan will be giving to astro_metadata_translator in this ticket when he reviews it.

          tjenness Tim Jenness added a comment - Right. The permission is effectively the same permission that womullan will be giving to astro_metadata_translator in this ticket when he reviews it.
          ktl Kian-Tat Lim made changes -
          Sprint Arch 2019-01-14 [ 851 ] Arch 2019-01-14, Arch 2019-01-21 [ 851, 852 ]

          When I look at your branch in githib https://github.com/lsst/astro_metadata_translator/blob/tickets/DM-17375/LICENSE   github still things its GPL .. which i guess it us until this ticket closes.   Otherwise looks good.

          womullan Wil O'Mullane added a comment - When I look at your branch in githib https://github.com/lsst/astro_metadata_translator/blob/tickets/DM-17375/LICENSE    github still things its GPL .. which i guess it us until this ticket closes.   Otherwise looks good.
          womullan Wil O'Mullane made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]

          If you think we need to also do this in other packages and its not in conflict then please go ahead.

          womullan Wil O'Mullane added a comment - If you think we need to also do this in other packages and its not in conflict then please go ahead.
          tjenness Tim Jenness added a comment -

          Much to my surprise, as soon as I merged GitHub changed the license banner to BSD.

          tjenness Tim Jenness added a comment - Much to my surprise, as soon as I merged GitHub changed the license banner to BSD.

          and on the branch as well so the banner must come from master always I suppose.

          womullan Wil O'Mullane added a comment - and on the branch as well so the banner must come from master always I suppose.
          tjenness Tim Jenness added a comment -

          womullan as we discussed on Wednesday I've also updated the license files in obs_lsst: I have stated BSD for translators and added the GPL and COPYRIGHT file to the root to meet the current standard. Can you or ktl please take a look at the obs_lsst pull request?

          tjenness Tim Jenness added a comment - womullan as we discussed on Wednesday I've also updated the license files in obs_lsst: I have stated BSD for translators and added the GPL and COPYRIGHT file to the root to meet the current standard. Can you or ktl please take a look at the obs_lsst pull request?
          tjenness Tim Jenness made changes -
          Component/s obs_lsst [ 16504 ]
          tjenness Tim Jenness added a comment -

          Merged. Thank you ktl and womullan for your reviews.

          tjenness Tim Jenness added a comment - Merged. Thank you ktl and womullan for your reviews.
          tjenness Tim Jenness made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          tjenness Tim Jenness made changes -
          Story Points 1 2
          tjenness Tim Jenness made changes -
          Epic Link DM-16576 [ 234914 ]

          People

            tjenness Tim Jenness
            tjenness Tim Jenness
            Wil O'Mullane
            John Swinbank, Jonathan Sick, Kian-Tat Lim, Tim Jenness, Wil O'Mullane
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.