Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17376

remove _camera global from obs_lsst

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Team:
      DM Science

      Description

      Splitting the _camera work from DM-17291 as it's separate (and more complex) than the _lsstCamMapper work.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17387 Add obs_lsst to the lsst_obs table file

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16298 Refactor YAML camera construction

          • To Do
          split from

          Improvement - An improvement or enhancement to an existing feature or task. DM-17291 Remove globals from obs_lsst

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rhl Robert Lupton created issue -
            rhl Robert Lupton made changes -
            Field Original Value New Value
            Link This issue split from DM-17291 [ DM-17291 ]
            tjenness Tim Jenness made changes -
            Description Splitting the {{_camera} work from DM-17291 as it's separate (and more complex) than the {{_lsstCamMapper}} work. Splitting the {{_camera}} work from DM-17291 as it's separate (and more complex) than the {{_lsstCamMapper}} work.
            tjenness Tim Jenness made changes -
            Team Data Release Production [ 10301 ]
            tjenness Tim Jenness made changes -
            Labels SciencePipelines
            Hide
            Permalink
            rhl Robert Lupton added a comment - - edited

            Note that there is also a DM-17376 branch for obs_base, and you need the DM-17446 branch of ip_isr to run ci_lsst.  I think that both PRs exists, although Jira doesn't seem to have noticed

            Show
            rhl Robert Lupton added a comment - - edited Note that there is also a DM-17376 branch for obs_base, and you need the  DM-17446 branch of ip_isr to run ci_lsst.  I think that both PRs exists, although Jira doesn't seem to have noticed
            rhl Robert Lupton made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I can't see a DM-17446 branch in ip_isr (or a pull request). There is a u/rhl/... branch though.

            Show
            tjenness Tim Jenness added a comment - I can't see a DM-17446 branch in ip_isr (or a pull request). There is a u/rhl/... branch though.
            tjenness Tim Jenness made changes -
            Assignee Robert Lupton [ rhl ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I have reviewed the obs_base branch and obs_lsst branch. I can't find a ip_isr branch. The obs_lsst changes look okay in general but there are many rebase errors that need fixing (I had touched most of the classes you changed). I also have a problem with the VisitInfo logic.

            Show
            tjenness Tim Jenness added a comment - I have reviewed the obs_base branch and obs_lsst branch. I can't find a ip_isr branch. The obs_lsst changes look okay in general but there are many rebase errors that need fixing (I had touched most of the classes you changed). I also have a problem with the VisitInfo logic.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Link This issue blocks DM-17387 [ DM-17387 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            I thought that Christopher Waters had pushed it.  Please use u/rhl/overscanNumLeadingColumnsToSkip for testing – these fixes are independent of the work on this ticket.

            Show
            rhl Robert Lupton added a comment - I thought that Christopher Waters had pushed it.  Please use u/rhl/overscanNumLeadingColumnsToSkip for testing – these fixes are independent of the work on this ticket.
            rhl Robert Lupton made changes -
            Link This issue is blocked by DM-17446 [ DM-17446 ]
            tjenness Tim Jenness made changes -
            Link This issue is blocked by DM-17446 [ DM-17446 ]
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            Merged to master

            Show
            rhl Robert Lupton added a comment - Merged to master
            rhl Robert Lupton made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            swinbank John Swinbank made changes -
            Labels SciencePipelines
            swinbank John Swinbank made changes -
            Team Data Release Production [ 10301 ] DM Science [ 12218 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-16298 [ DM-16298 ]

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Tim Jenness
              Watchers:
              Colin Slater, John Swinbank, Leanne Guy, Robert Lupton, Tim Jenness, Wil O'Mullane
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.