Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17426

Improve full-visit sky subtraction

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Team:
      External

      Description

      The current full-visit sky subtraction is not perfect; in particular, there are some negative residuals around the edge of the field of view. Michitaro Koike is investigating potential improvements, including the use of PCA.

        Attachments

        1. 2019-03-13HSC-G.png
          2019-03-13HSC-G.png
          1.19 MB
        2. 2019-03-13-HSC-I2.png
          2019-03-13-HSC-I2.png
          1.09 MB
        3. dark-edge.png
          dark-edge.png
          23 kB
        4. ds9.png
          ds9.png
          185 kB
        5. HSC-G.png
          HSC-G.png
          1.68 MB
        6. HSC-I2.png
          HSC-I2.png
          1.64 MB
        7. image-2019-02-25-16-15-26-177.png
          image-2019-02-25-16-15-26-177.png
          703 kB
        8. multipass-mask.py
          2 kB
        9. Screen Shot 2019-02-08 at 15.31.00.png
          Screen Shot 2019-02-08 at 15.31.00.png
          328 kB
        10. Screen Shot 2019-02-25 at 16.01.11.png
          Screen Shot 2019-02-25 at 16.01.11.png
          696 kB
        11. smootharray.html
          389 kB
        12. Unknown-2.png
          Unknown-2.png
          43 kB
        13. Unknown-3.png
          Unknown-3.png
          33 kB

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            I implemented the review feedback on Michitaro Koike's ticket, and then ran the same tests he had been running in Japan. He writes:

            The new camera images look good and are the same as what I made.
            I believe that your refactoring was perfect.

            I will run Jenkins and then merge.

            Show
            price Paul Price added a comment - I implemented the review feedback on Michitaro Koike 's ticket, and then ran the same tests he had been running in Japan. He writes: The new camera images look good and are the same as what I made. I believe that your refactoring was perfect. I will run Jenkins and then merge.
            Hide
            price Paul Price added a comment -

            Jenkins passed.

            Show
            price Paul Price added a comment - Jenkins passed.
            Hide
            price Paul Price added a comment -

            Merged to master.

            Show
            price Paul Price added a comment - Merged to master.
            Hide
            michitaro.nike Michitaro Koike added a comment -

            Thanks!

            Show
            michitaro.nike Michitaro Koike added a comment - Thanks!
            Hide
            michitaro.nike Michitaro Koike added a comment -

            I found that we should make a fix on smoothArray.
            https://github.com/lsst/pipe_drivers/blob/master/python/lsst/pipe/drivers/background.py#L848
            We do not need to multiply numerator on the resultant image.
            The current implementation produces resultant image with relatively dark edges if given sigma is large.

            A comparison between the current one and the proposed one can be seen at smootharray.html.

            Show
            michitaro.nike Michitaro Koike added a comment - I found that we should make a fix on smoothArray . https://github.com/lsst/pipe_drivers/blob/master/python/lsst/pipe/drivers/background.py#L848 We do not need to multiply numerator on the resultant image. The current implementation produces resultant image with relatively dark edges if given sigma is large. A comparison between the current one and the proposed one can be seen at smootharray.html .

              People

              • Assignee:
                michitaro.nike Michitaro Koike
                Reporter:
                price Paul Price
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, Masayuki Tanaka, Michitaro Koike, Paul Price, Robert Lupton
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel