Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17427

Incorporate Goulding bright star masks

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Team:
      External

      Description

      Andy Goulding (Princeton) has delivered some improved bright star masks. These need to be installed and tested.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            RFC-578+DM-18147 created to have the new masks installed on the LSST cluster.

            Show
            price Paul Price added a comment - RFC-578 + DM-18147 created to have the new masks installed on the LSST cluster.
            Hide
            price Paul Price added a comment -

            Nate Lust, would you be willing to review this?

            price@MacBook:~/LSST/pipe_tasks (tickets/DM-17427=) $ git sub
            commit 833810dd133d87b83bd7c51da5f65307ccf95402 (HEAD -> tickets/DM-17427, origin/tickets/DM-17427)
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Tue Feb 26 17:23:15 2019 -0500
             
                objectMasks: update parser to handle Goulding mask format
                
                Andy Goulding has provided new masks based on Gaia DR2, and with a
                better tuned size; but the format is subtly different:
                * The rotation angle of a 'box' is not specified (it’s supposed to be
                  zero anyway).
                * The 'ID:' string is replaced with 'Gaia DR2'.
                * Floating point values use scientific notation in places.
                
                We've decided that (apart from the lack of "ID:", which we want in
                order to be explicit) it's best to update the parser rather than fix
                the mask files: the differences from what we have been expecting are
                reasonable, and fixing the parser now means we may not have to fix
                it much for the next version.
                
                Expanded the regex to support the new format, defaulting the
                rotation angle of boxes to 0. Added comments to the regex so it's
                easier to understand.
             
             python/lsst/pipe/tasks/objectMasks.py | 29 ++++++++++++++++++-----------
             1 file changed, 18 insertions(+), 11 deletions(-)
             
             
            price@MacBook:~/LSST/ci_hsc (tickets/DM-17427=) $ git sub
            commit e9ac9d6afb4cc48300dc4f49fd002689540f7bd6 (HEAD -> tickets/DM-17427, origin/tickets/DM-17427)
            Author: Paul Price <price@astro.princeton.edu>
            Date:   Thu Feb 28 12:11:31 2019 -0500
             
                update brightObjectMasks to Goulding version
                
                Andy Goulding has provided a new set of bright object masks, which we'd
                like to use moving forward. These replace the masks provided by Jean
                Coupon, as they have been judged to be an improvement for science users.
             
             .../0/BrightObjectMask-0-5,4-HSC-I.reg             | 4504 +++++++++++++++++--
             .../0/BrightObjectMask-0-5,4-HSC-R.reg             | 4648 ++++++++++++++++++--
             brightObjectMasks/README.txt                       |   61 +-
             3 files changed, 8296 insertions(+), 917 deletions(-)
            

            Show
            price Paul Price added a comment - Nate Lust , would you be willing to review this? price@MacBook:~/LSST/pipe_tasks (tickets/DM-17427=) $ git sub commit 833810dd133d87b83bd7c51da5f65307ccf95402 (HEAD -> tickets/DM-17427, origin/tickets/DM-17427) Author: Paul Price <price@astro.princeton.edu> Date: Tue Feb 26 17:23:15 2019 -0500   objectMasks: update parser to handle Goulding mask format Andy Goulding has provided new masks based on Gaia DR2, and with a better tuned size; but the format is subtly different: * The rotation angle of a 'box' is not specified (it’s supposed to be zero anyway). * The 'ID:' string is replaced with 'Gaia DR2'. * Floating point values use scientific notation in places. We've decided that (apart from the lack of "ID:", which we want in order to be explicit) it's best to update the parser rather than fix the mask files: the differences from what we have been expecting are reasonable, and fixing the parser now means we may not have to fix it much for the next version. Expanded the regex to support the new format, defaulting the rotation angle of boxes to 0. Added comments to the regex so it's easier to understand.   python/lsst/pipe/tasks/objectMasks.py | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-)     price@MacBook:~/LSST/ci_hsc (tickets/DM-17427=) $ git sub commit e9ac9d6afb4cc48300dc4f49fd002689540f7bd6 (HEAD -> tickets/DM-17427, origin/tickets/DM-17427) Author: Paul Price <price@astro.princeton.edu> Date: Thu Feb 28 12:11:31 2019 -0500   update brightObjectMasks to Goulding version Andy Goulding has provided a new set of bright object masks, which we'd like to use moving forward. These replace the masks provided by Jean Coupon, as they have been judged to be an improvement for science users.   .../0/BrightObjectMask-0-5,4-HSC-I.reg | 4504 +++++++++++++++++-- .../0/BrightObjectMask-0-5,4-HSC-R.reg | 4648 ++++++++++++++++++-- brightObjectMasks/README.txt | 61 +- 3 files changed, 8296 insertions(+), 917 deletions(-)
            Hide
            price Paul Price added a comment - - edited

            Demonstration of the Goulding S18A mask applied to the i-band in ci_hsc:

            Note that the circles seem large because we're dealing with only 30 sec exposures, rather than the usual 300 sec exposures from the HSC survey.

            Show
            price Paul Price added a comment - - edited Demonstration of the Goulding S18A mask applied to the i-band in ci_hsc: Note that the circles seem large because we're dealing with only 30 sec exposures, rather than the usual 300 sec exposures from the HSC survey.
            Hide
            nlust Nate Lust added a comment -

            One small comment to consider about rotation angles, but I don't have strong feelings on it, just something worth thought. Feel free to talk with me about it, but once you feel ready, go ahead and merge. I dont need to see it again unless there are large changes you end up making.

            Show
            nlust Nate Lust added a comment - One small comment to consider about rotation angles, but I don't have strong feelings on it, just something worth thought. Feel free to talk with me about it, but once you feel ready, go ahead and merge. I dont need to see it again unless there are large changes you end up making.
            Hide
            price Paul Price added a comment -

            Thanks for the review, Nate Lust. I believe I addressed your comment on the PR.

            Merged to master.

            Show
            price Paul Price added a comment - Thanks for the review, Nate Lust . I believe I addressed your comment on the PR. Merged to master.

              People

              • Assignee:
                price Paul Price
                Reporter:
                price Paul Price
                Reviewers:
                Nate Lust
                Watchers:
                Jim Bosch, Masayuki Tanaka, Nate Lust, Paul Price
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel