Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_lsst
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Arch 2019-01-28
-
Team:Architecture
Description
In obs_lsst #43 Craig Lage has added support for the UC Davis camera to obs_lsst.
We need to shepherd this through adoption into the DM codebase.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Description |
In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.
Per assorted discussions, this seems like a good thing to have. We should have somebody do a review of the code (I believe [~mfisherlevine] has already done much of this...) and to make sure that it's covered by the test suite (which I haven't properly investigated, but it looks as though adding some UCDCam data to https://github.com/lsst-dm/testdata_obs_lsst would be a good start). |
In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.
Per assorted discussions, this seems like a good thing to have. We should have somebody do a review of the code (I believe [~mfisherlevine] has already done much of this...) and to make sure that it's covered by the test suite (which I haven't properly investigated, but it looks as though adding some UCDCam data to [https://github.com/lsst-dm/testdata_obs_lsst] would be a good start). Plan of action * [~cslage] provides some naked headers to [~tjenness] (naked == without the data) * [~tjenness], like a saint, ports the header translation to `astro_metadata_translator` * Tests are written, both obs.base.test/pytest style ones, and `ci_lsst` ones using the data John refers to above. * [~cslage] tidies up the code to remove the crufty/vestigial sensors that are there due to copying ts8 code instead of AuxTel code * Merlin reviews the full changeset post-tidy-up * We merge * Everyone goes home happy. |
| Description |
In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.
Per assorted discussions, this seems like a good thing to have. We should have somebody do a review of the code (I believe [~mfisherlevine] has already done much of this...) and to make sure that it's covered by the test suite (which I haven't properly investigated, but it looks as though adding some UCDCam data to [https://github.com/lsst-dm/testdata_obs_lsst] would be a good start). Plan of action * [~cslage] provides some naked headers to [~tjenness] (naked == without the data) * [~tjenness], like a saint, ports the header translation to `astro_metadata_translator` * Tests are written, both obs.base.test/pytest style ones, and `ci_lsst` ones using the data John refers to above. * [~cslage] tidies up the code to remove the crufty/vestigial sensors that are there due to copying ts8 code instead of AuxTel code * Merlin reviews the full changeset post-tidy-up * We merge * Everyone goes home happy. |
In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.
We need to shepherd this through adoption into the DM codebase. |
| Watchers | John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness [ John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness ] | Craig Lage, John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness [ Craig Lage, John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness ] |
| Assignee | Tim Jenness [ tjenness ] |
| Team | Data Release Production [ 10301 ] | Architecture [ 10304 ] |
| Epic Link |
|
| Sprint | Arch 2019-01-28 [ 853 ] |
| Reviewers | Merlin Fisher-Levine [ mfisherlevine ] | |
| Status | To Do [ 10001 ] | In Review [ 10004 ] |
| Reviewers | Merlin Fisher-Levine [ mfisherlevine ] | Robert Lupton [ rhl ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Epic Link |
|