Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17437

Add UC Davis camera support to obs_lsst

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None

      Description

      In obs_lsst #43 Craig Lage has added support for the UC Davis camera to obs_lsst.

      We need to shepherd this through adoption into the DM codebase.
       

        Attachments

          Activity

          swinbank John Swinbank created issue -
          swinbank John Swinbank made changes -
          Field Original Value New Value
          Epic Link DM-16678 [ 235238 ]
          mfisherlevine Merlin Fisher-Levine made changes -
          Description In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.

          Per assorted discussions, this seems like a good thing to have.

          We should have somebody do a review of the code (I believe [~mfisherlevine] has already done much of this...) and to make sure that it's covered by the test suite (which I haven't properly investigated, but it looks as though adding some UCDCam data to https://github.com/lsst-dm/testdata_obs_lsst would be a good start).
          In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.

          Per assorted discussions, this seems like a good thing to have.

          We should have somebody do a review of the code (I believe [~mfisherlevine] has already done much of this...) and to make sure that it's covered by the test suite (which I haven't properly investigated, but it looks as though adding some UCDCam data to [https://github.com/lsst-dm/testdata_obs_lsst] would be a good start).

          Plan of action
           * [~cslage] provides some naked headers to [~tjenness] (naked == without the data)
           * [~tjenness], like a saint, ports the header translation to `astro_metadata_translator`
           * Tests are written, both obs.base.test/pytest style ones, and `ci_lsst` ones using the data John refers to above.
           * [~cslage] tidies up the code to remove the crufty/vestigial sensors that are there due to copying ts8 code instead of AuxTel code
           * Merlin reviews the full changeset post-tidy-up
           * We merge
           * Everyone goes home happy.

           
          swinbank John Swinbank made changes -
          Description In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.

          Per assorted discussions, this seems like a good thing to have.

          We should have somebody do a review of the code (I believe [~mfisherlevine] has already done much of this...) and to make sure that it's covered by the test suite (which I haven't properly investigated, but it looks as though adding some UCDCam data to [https://github.com/lsst-dm/testdata_obs_lsst] would be a good start).

          Plan of action
           * [~cslage] provides some naked headers to [~tjenness] (naked == without the data)
           * [~tjenness], like a saint, ports the header translation to `astro_metadata_translator`
           * Tests are written, both obs.base.test/pytest style ones, and `ci_lsst` ones using the data John refers to above.
           * [~cslage] tidies up the code to remove the crufty/vestigial sensors that are there due to copying ts8 code instead of AuxTel code
           * Merlin reviews the full changeset post-tidy-up
           * We merge
           * Everyone goes home happy.

           
          In [obs_lsst #43|https://github.com/lsst/obs_lsst/pull/43] [~cslage] has added support for the UC Davis camera to obs_lsst.

          We need to shepherd this through adoption into the DM codebase.
           
          tjenness Tim Jenness made changes -
          Watchers John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness [ John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness ] Craig Lage, John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness [ Craig Lage, John Swinbank, Merlin Fisher-Levine, Simon Krughoff, Tim Jenness ]
          tjenness Tim Jenness made changes -
          Assignee Tim Jenness [ tjenness ]
          tjenness Tim Jenness made changes -
          Team Data Release Production [ 10301 ] Architecture [ 10304 ]
          tjenness Tim Jenness made changes -
          Epic Link DM-16678 [ 235238 ]
          tjenness Tim Jenness made changes -
          Sprint Arch 2019-01-28 [ 853 ]
          tjenness Tim Jenness made changes -
          Reviewers Merlin Fisher-Levine [ mfisherlevine ]
          Status To Do [ 10001 ] In Review [ 10004 ]
          tjenness Tim Jenness made changes -
          Reviewers Merlin Fisher-Levine [ mfisherlevine ] Robert Lupton [ rhl ]
          rhl Robert Lupton made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          tjenness Tim Jenness made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          tjenness Tim Jenness made changes -
          Epic Link DM-16576 [ 234914 ]

            People

            Assignee:
            tjenness Tim Jenness
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Robert Lupton
            Watchers:
            Craig Lage, John Swinbank, Merlin Fisher-Levine, Robert Lupton, Simon Krughoff, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.