Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17449

Photocal not setting up DirectMatchTask correctly

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      DRP S19-2
    • Team:
      Data Release Production

      Description

      PhotoCalTask passes a config object as the first argument to the DirectMatchTask constructor, however DirectMatchTask defines butler as its first argument, not config. This causes the config object to be assigned to the butler argument. If the referenceObjectLoader is passed to DirectMatchTask's constructor then this has no impact. However if the referenceObjectLoader is None this will cause the task to fail.

      See:
      https://github.com/lsst/pipe_tasks/blob/master/python/lsst/pipe/tasks/photoCal.py#L256
      and:
      https://github.com/lsst/meas_astrom/blob/master/python/lsst/meas/astrom/directMatch.py#L42

        Attachments

          Activity

          Hide
          nlust Nate Lust added a comment -
          Show
          nlust Nate Lust added a comment - Pull request: https://github.com/lsst/pipe_tasks/pull/262
          Hide
          ctslater Colin Slater added a comment -

          Looks good. I'm not sure how I left that positional argument there in the first place.

          Show
          ctslater Colin Slater added a comment - Looks good. I'm not sure how I left that positional argument there in the first place.

            People

            Assignee:
            nlust Nate Lust
            Reporter:
            nlust Nate Lust
            Reviewers:
            Colin Slater
            Watchers:
            Colin Slater, Nate Lust
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.