Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17452

slots are not propagated into MultiMatch output schema

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      I discovered DM-17451 because the output schema produced by MultiMatch does not include the slots that were defined on the input catalog, even if you ensure that they are defined on the schema that is passed in to MultiMatch.

      I suspect a trivial fix for this is to add outSchema.setAliasMap(self.mapper.getInputSchema.getAliasMap()) to multiMatch.py around line 37.

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            It does look like the fix was as trivial as described. We'll see what Jenkins thinks: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29317/pipeline

            Show
            Parejkoj John Parejko added a comment - It does look like the fix was as trivial as described. We'll see what Jenkins thinks: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29317/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Michael Wood-Vasey: would you be able to review this one-line bugfix? For my use case (DM-17256) the slots are now being properly propagated.

            Please let me know if there was a reason you had not propagated the aliases before; personally, I was surprised that the schema mapper didn't just take them along for the ride by default.

            Show
            Parejkoj John Parejko added a comment - Michael Wood-Vasey : would you be able to review this one-line bugfix? For my use case ( DM-17256 ) the slots are now being properly propagated. Please let me know if there was a reason you had not propagated the aliases before; personally, I was surprised that the schema mapper didn't just take them along for the ride by default.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Looks good to me.

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Looks good to me.
            Hide
            wmwood-vasey Michael Wood-Vasey added a comment -

            Please let me know if there was a reason you had not propagated the aliases before; personally, I was surprised that the schema mapper didn't just take them along for the ride by default.

            Sorry, at whom are you directing this question?

            I think Jim Bosch described this section of code accurately in his original commit as "Quick-and-dirty code for multi-way matching."

            Show
            wmwood-vasey Michael Wood-Vasey added a comment - Please let me know if there was a reason you had not propagated the aliases before; personally, I was surprised that the schema mapper didn't just take them along for the ride by default. Sorry, at whom are you directing this question? I think Jim Bosch described this section of code accurately in his original commit as "Quick-and-dirty code for multi-way matching."
            Hide
            Parejkoj John Parejko added a comment -

            Sorry, at whom are you directing this question?

            I think Jim Bosch described this section of code accurately in his original commit as "Quick-and-dirty code for multi-way matching."

            Whoops! Sorry, I thought you'd written this code originally (because of its use in validate_drp). I guess the question goes to Jim Bosch, but I think you answered it appropriately above.

            Thanks for the quick review.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Sorry, at whom are you directing this question? I think Jim Bosch described this section of code accurately in his original commit as "Quick-and-dirty code for multi-way matching." Whoops! Sorry, I thought you'd written this code originally (because of its use in validate_drp). I guess the question goes to Jim Bosch , but I think you answered it appropriately above. Thanks for the quick review. Merged and done.

              People

              • Assignee:
                Parejkoj John Parejko
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Michael Wood-Vasey
                Watchers:
                Jim Bosch, John Parejko, John Swinbank, Michael Wood-Vasey, Paul Price, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: