The Gen3 formatter class for HSC raw data doesn't call setFilter on the returned Exposure, which is a problem for downstream processing. To fix that, we need to:
- add a makeFilter to FitsRawExposureFormatterBase in daf_butler, similar to the existing makeWcs and makeVisitInfo (including using it in the base class readInfoComponent.
- implement makeFilter in obs_subaru appropriately.
We'll probably have to call the afw.image.Filter constructor with force=True to try to avoid mucking with the global variables (and hope no one else does); a better solution will have to wait for RFC-541.
Story
Nate Lust, I think this should fix the problem you're seeing in reading reference catalogs, though I'd appreciate a test of that because I've tried to avoid populating the Filter global variables in the hopes we don't need them for this.
PRs are:
Note that these are branched from master, not
DM-17489, so you'll need to make your own working branches if you want to use them together (I'm assuming this one will merge first, and then I'll rebaseDM-17489).