Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17511

Update ATMCS simulator based on updated XML and new knowledge

    Details

      Description

      The ATMCS simulator has some issues that need addressing:

      • Updated XML, including M3 telemetry
      • Motors should be enabled by standby->disabled and vice versa (the current logic is more complicated). That said, we are discussing whether there is some way to only enable a rotator if it is needed, in order to reduce heat load.
      • Update limits based on current knowledge
      • Output azimuth raw encoder counts in range [0, 360]*resolution and offset encoders by appropriate amounts when there are multiple encoders per axis
      • Do not output m3InPosition and probably not m3PortSelected (Rolando Cantarutti?) until the setInstrumentPort command is received.
      • Enable tests that were accidentally left disabled

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Pull request: https://github.com/lsst-ts/ts_ATMCSSimulator/pull/3
            Requires tickets/DM-17227 of ts_xml until that ticket is merged

            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_ATMCSSimulator/pull/3 Requires tickets/ DM-17227 of ts_xml until that ticket is merged
            Hide
            ecoughlin Eric Coughlin added a comment -

            Code looks good and complete.

            Show
            ecoughlin Eric Coughlin added a comment - Code looks good and complete.
            Hide
            rbovill Rob Bovill added a comment -

            Task is complete.

            Show
            rbovill Rob Bovill added a comment - Task is complete.
            Hide
            rowen Russell Owen added a comment -

            Merged to develop and master, released as v0.2.0

            Show
            rowen Russell Owen added a comment - Merged to develop and master, released as v0.2.0

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                rowen Russell Owen
                Reviewers:
                Patrick Ingraham
                Watchers:
                Andres Anania [X] (Inactive), Eric Coughlin, Patrick Ingraham, Rob Bovill, Rolando Cantarutti, Russell Owen, Tiago Ribeiro
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Start date:
                  End date:

                  Summary Panel