Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17522

Write getting started notes on ip_diffim

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None
    • Story Points:
      8
    • Epic Link:
    • Sprint:
      AP S19-3, AP S19-4, AP S19-5
    • Team:
      Alert Production

      Description

      Take what you learned on DM-16409 and turn it into a set of notes on the ip_diffim codebase — what are the key options? How is the code structured?

      This shouldn't attempt to be comprehensive, user focused documentation: use it to draw out the key themes and options that you think we should schedule time to investigate over the next several months, and record what you wish you'd known when you were getting started a few months ago.

        Attachments

          Issue Links

            Activity

            Hide
            gkovacs Gabor Kovacs added a comment -

            Could you please review my page of loose thoughts on the ImageDifferenceTask usage and some implementation aspects?

            Show
            gkovacs Gabor Kovacs added a comment - Could you please review my page of loose thoughts on the ImageDifferenceTask usage and some implementation aspects?
            Hide
            mrawls Meredith Rawls added a comment -

            The notes mostly look fine. I left some comments on GitHub I'd like resolved, please, but I think having these notes land in the documentation for ip_diffim is reasonable and will help future folks figure out what is happening.

            Show
            mrawls Meredith Rawls added a comment - The notes mostly look fine. I left some comments on GitHub I'd like resolved, please, but I think having these notes land in the documentation for ip_diffim is reasonable and will help future folks figure out what is happening.
            Hide
            swinbank John Swinbank added a comment -

            Hi Gabor Kovacs, Meredith Rawls — this work has been in review for over a month. Are there any blockers? Can we do something to get it completed soon? Thanks!

            Show
            swinbank John Swinbank added a comment - Hi Gabor Kovacs , Meredith Rawls — this work has been in review for over a month. Are there any blockers? Can we do something to get it completed soon? Thanks!
            Hide
            gkovacs Gabor Kovacs added a comment -

            Meredith Rawls - Reflected on github to your comments; also rebased and updated branch as requested.

            This is consistent with my experience with imageDifferenceTask, but this appears to be a decam-specific example. Other cameras don't necessarily have a "visit id" as you describe here; what would the user need to specify for a templateId in that situation?

            Reference to a "visit id" field originated from an old piece of command line argument description. Updated. The code in GetCalexpAsTemplateTask did not explicitly use it, though contained a hard-wired reference to 'visit' in one code branch for a log message. Removed. Please note, this resulted in a new PR for pipe_tasks.

            Show
            gkovacs Gabor Kovacs added a comment - Meredith Rawls - Reflected on github to your comments; also rebased and updated branch as requested. This is consistent with my experience with imageDifferenceTask, but this appears to be a decam-specific example. Other cameras don't necessarily have a "visit id" as you describe here; what would the user need to specify for a templateId in that situation? Reference to a "visit id" field originated from an old piece of command line argument description. Updated. The code in GetCalexpAsTemplateTask did not explicitly use it, though contained a hard-wired reference to 'visit' in one code branch for a log message. Removed. Please note, this resulted in a new PR for pipe_tasks.
            Hide
            mrawls Meredith Rawls added a comment -

            Looks good!

            Show
            mrawls Meredith Rawls added a comment - Looks good!

              People

              • Assignee:
                gkovacs Gabor Kovacs
                Reporter:
                swinbank John Swinbank
                Reviewers:
                Meredith Rawls
                Watchers:
                Eric Bellm, Gabor Kovacs, John Swinbank, Meredith Rawls
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel