Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17549

Add schema version to LSST alert schema

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      AP S19-3, AP S19-4, AP S19-5, AP S19-6
    • Team:
      Alert Production

      Description

      Each alert packet should record the version of the schema which was used to generate it.

      Also include some instructions for backwards compatibility.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            I believe I've addressed all the review comments on sample-avro-alert. Still to tackle alert_stream (and it will be broken now, given some of the changes on sample-avro-alert). Watch this space.

            Show
            swinbank John Swinbank added a comment - I believe I've addressed all the review comments on sample-avro-alert. Still to tackle alert_stream (and it will be broken now, given some of the changes on sample-avro-alert). Watch this space.
            Hide
            swinbank John Swinbank added a comment -

            Ok, I think both alert_stream and sample-avro-alert are now ready for you to take another look, Eric Bellm.

            I responded to a number of your comments on GitHub, but I'm concerned that it may have clobbered my answers when I force-pushed my updated branch. Probably you got them by e-mail, but if you think there's something I've missed please let me know and I'll try to reconstruct my response.

            Show
            swinbank John Swinbank added a comment - Ok, I think both alert_stream and sample-avro-alert are now ready for you to take another look, Eric Bellm . I responded to a number of your comments on GitHub, but I'm concerned that it may have clobbered my answers when I force-pushed my updated branch. Probably you got them by e-mail, but if you think there's something I've missed please let me know and I'll try to reconstruct my response.
            Hide
            swinbank John Swinbank added a comment - - edited

            For reference, I spawned a number of tickets related to work here.

            The following are directly related to review comments:

            • DM-19255 — Allow more flexibility and realism when generating pseudorandom alert packets
            • DM-19257 — validateAvroRoundTrip.py should be a test case
            • DM-19264 — Upstream fastavro schema resolution
            • DM-19587 — Overhaul lsst.alert.packet test suite
            • DM-19588 — Develop test mechanisms for alert distribution system
            • DM-19597 — Provide Avro-alert pretty-printer

            The following are “inspired” by the work I did here, or by review discussion, but are not directly implementing Eric Bellm's requests:

            • DM-19557 — Review docker-compose.yml settings for alert_stream
            • DM-19590 — Standardize alert distribution system deployment tools
            • DM-19586 — Adopt a plugin system for alert filters
            • DM-19589 — Audit dependencies in lsst-dm/alert_stream/Dockerfile
            • DM-19606 — Rethink alert distribution dockerization
            • DM-19584 — Refactor alert distribution system repositories
            Show
            swinbank John Swinbank added a comment - - edited For reference, I spawned a number of tickets related to work here. The following are directly related to review comments: DM-19255 — Allow more flexibility and realism when generating pseudorandom alert packets DM-19257 — validateAvroRoundTrip.py should be a test case DM-19264 — Upstream fastavro schema resolution DM-19587 — Overhaul lsst.alert.packet test suite DM-19588 — Develop test mechanisms for alert distribution system DM-19597 — Provide Avro-alert pretty-printer The following are “inspired” by the work I did here, or by review discussion, but are not directly implementing Eric Bellm 's requests: DM-19557 — Review docker-compose.yml settings for alert_stream DM-19590 — Standardize alert distribution system deployment tools DM-19586 — Adopt a plugin system for alert filters DM-19589 — Audit dependencies in lsst-dm/alert_stream/Dockerfile DM-19606 — Rethink alert distribution dockerization DM-19584 — Refactor alert distribution system repositories
            Hide
            swinbank John Swinbank added a comment -

            Going to go ahead and merge approved PRs on sample-avro-alert and DMTN-093 while review is still on progress on alert-stream, per this suggestion.

            Show
            swinbank John Swinbank added a comment - Going to go ahead and merge approved PRs on sample-avro-alert and DMTN-093 while review is still on progress on alert-stream, per this suggestion .
            Hide
            swinbank John Swinbank added a comment -

            Merged & done. Thanks Eric Bellm

            Show
            swinbank John Swinbank added a comment - Merged & done. Thanks Eric Bellm

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Eric Bellm
              Watchers:
              Eric Bellm, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: