Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17552

Check SQuaSH metric regressions using Match PessimisticB

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None

      Description

      After the new matcher (Pessimistic B) became default on DM-14857, the astrometric metrics recorded on SQuaSH regressed (for both HSC and CFHT). Reproduce this locally and understand what happened. Fix if this is a matcher problem; if it's a validate_drp problem, ticket that for future work.

        Attachments

          Issue Links

            Activity

            Hide
            cmorrison Chris Morrison added a comment -

            I've updated the comment in the ticket. I'm waiting on either John Swinbank or yourself, Yusra AlSayyad to give it a thumbs up. I'm ready to merge once that happens.

            Show
            cmorrison Chris Morrison added a comment - I've updated the comment in the ticket. I'm waiting on either John Swinbank or yourself, Yusra AlSayyad to give it a thumbs up. I'm ready to merge once that happens.
            Hide
            swinbank John Swinbank added a comment - - edited

            Chris Morrison — a couple of things:

            • Could you take another pass through the commit messages? I still see an “interative” there, as well as a couple of “explaination”s.
            • I actually think the comment you've written here on this ticket is more informative than the one you added to the source. Do you think you could adapt it? Something like:

            The shift/rotation matrix returned by ``_construct_pattern_and_shift_rot_matrix``, above, was based on only six points. Here, we refine that result by using all of the good matches from the “final verification” step, above. This will produce a more consistent result.

            perhaps?

            Show
            swinbank John Swinbank added a comment - - edited Chris Morrison — a couple of things: Could you take another pass through the commit messages? I still see an “interative” there, as well as a couple of “explaination”s. I actually think the comment you've written here on this ticket is more informative than the one you added to the source. Do you think you could adapt it? Something like: The shift/rotation matrix returned by ``_construct_pattern_and_shift_rot_matrix``, above, was based on only six points. Here, we refine that result by using all of the good matches from the “final verification” step, above. This will produce a more consistent result. perhaps?
            Hide
            cmorrison Chris Morrison added a comment -

            Done, sorry I forgot about the typo in the commit. I double checked and the Cfht values are the same as I reported above. Let me know when I'm clear to merge.

            Show
            cmorrison Chris Morrison added a comment - Done, sorry I forgot about the typo in the commit. I double checked and the Cfht values are the same as I reported above. Let me know when I'm clear to merge.
            Hide
            swinbank John Swinbank added a comment -

            . Go for it.

            Show
            swinbank John Swinbank added a comment - . Go for it.
            Hide
            cmorrison Chris Morrison added a comment -

            Fingers crosses that the squash metrics improve as I have seen. Talked to Simon Krughoff this morning and he said that squash will run with this version tomorrow morning.

            Show
            cmorrison Chris Morrison added a comment - Fingers crosses that the squash metrics improve as I have seen. Talked to Simon Krughoff this morning and he said that squash will run with this version tomorrow morning.

              People

              Assignee:
              cmorrison Chris Morrison
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Chris Morrison, John Swinbank, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.