Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17597

Update testdata_jointcal catalogs to be processed with gaia+ps1

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal
    • Labels:
      None
    • Story Points:
      28
    • Epic Link:
    • Sprint:
      AP S20-5 (April), AP S20-6 (May)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      At some point, we should update the jointcal testdata to reflect the latest processCcd output (e.g. using the new Pessimistic matcher) processed with a more modern reference catalog (likely PS1 for photometry, Gaia for astrometry). This should allow us to un-skip several of the existing tests (e.g. DeCAM photometry tests) that are currently skipped because of bad test data, and remove old-style sourceSelector flags, etc. This would also be the time to update testdata_jointcal to the gen3 butler format.

      As part of this work, we should investigate in detail the various chi2/ndof values computed by the tests (these were changed as part of DM-17595, without in-depth study). This would be the time to really test assumptions about e.g. no_rank_update or line search astrometry tests not changing the default chi2, when a highly accurate reference catalog is used (Gaia).

      I would expect this work to be delayed for a year or so, until all of the above pieces are nicely settled into place.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24428 Update fgcmcal tests to use new PS1 refcats

          • Done
          has to be finished together with

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14439 Explore numeric difference in Mac/Linux ConstrainedPhotometry fitting

          • Invalid
          is blocked by

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-19473 Create Gaia DR2 reference catalog

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24392 Update testdata_jointcal to include Gaia+PS1 refcats

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24472 Regenerate Gaia DR2 catalogs to correct coordinate error fields

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-25114 Update internal fgcm math to always use 64-bit floats

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-24976 Rework testdata_jointcal dependencies

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-697 Change CalibrateTask refcat defaults to Gaia DR2 for astrometry and PS1 for photometry

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16490 Update fgcmcal to use makeSkyWcs from camera geometry for sky/focal plane transforms

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24527 Update validation_data readmes and scripts about "recreating the repository"

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24602 extract simulated LSST data for testdata_jointcal

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17830 Investigate color-dependent offsets from ref cat in jointcal vs. meas_mosaic

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17595 Replace twinkles1 testdata with DC2+HTM refcat simulations

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            Well, even if the tests values don't change then the configs will have to be changed to reflect the new data formats (overrides can be removed, yay!).

            Show
            erykoff Eli Rykoff added a comment - Well, even if the tests values don't change then the configs will have to be changed to reflect the new data formats (overrides can be removed, yay!).
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31934/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31934/pipeline
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            Eli Rykoff are you still ok to review this? the testdata claims it's a tens of thousands of lines, but that's because of the data (please do have a look at the compression scripts and the README changes though!). The biggest change is jointcal itself, where in addition to the test value changes, I had to restructure some calculations. The commits in general should be atomic, and reviewing by commit may make it all more manageable.

            Here are the relevant PRs:

            Show
            Parejkoj John Parejko added a comment - - edited Eli Rykoff are you still ok to review this? the testdata claims it's a tens of thousands of lines, but that's because of the data (please do have a look at the compression scripts and the README changes though!). The biggest change is jointcal itself, where in addition to the test value changes, I had to restructure some calculations. The commits in general should be atomic, and reviewing by commit may make it all more manageable. Here are the relevant PRs: https://github.com/lsst/testdata_jointcal/pull/26 https://github.com/lsst/jointcal/pull/157 https://github.com/lsst/obs_decam/pull/153 https://github.com/lsst/validate_drp/pull/122 https://github.com/lsst/fgcmcal/pull/37 (I'll review this one, since you wrote it)
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            My part of the review is complete, but we need somebody (you, John Parejko?) to look at the fgcmcal PR.

            Show
            erykoff Eli Rykoff added a comment - My part of the review is complete, but we need somebody (you, John Parejko ?) to look at the fgcmcal PR.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks for the review, Eli Rykoff. I merged everything except obs_cfht, which I just closed with a note about RFC-697.

            Merged and done, after far too long!

            Show
            Parejkoj John Parejko added a comment - Thanks for the review, Eli Rykoff . I merged everything except obs_cfht, which I just closed with a note about RFC-697 . Merged and done, after far too long!

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.