Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_dome
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:TSSW Sprint - Feb 04 - Feb 16
-
Team:Telescope and Site
Description
Improve the ATPneumatics XML as per disussion with Rolando Cantarutti
- Ditch the Position events because they are fully duplicated by the limit switch events.
- Add Invalid mirror cover state to handle the case that both an open and a closed switch are active for the same cover.
- Ditch the overlap of the “state” enums with summary state and shorten the names to remove redundancy and stutter, so that the MirrorCoverState enums become:
<Enumeration>MirrorCovers_Closed,MirrorCovers_Opened,MirrorCovers_InMotionState, MirrorCovers_Invalid</Enumeration>
and the mirror vents state enum becomes:
<Enumeration>CellVents_Opened,CellVents_Closed,CellVents_InMotion</Enumeration>
- Delete the resetEStopTriggered event, rename the eStopTriggered event to eStopTrigger and set the triggered field appropriately.
- Add two new events for reporting m1 and m2 commanded air pressure (each with a single field), unless folks have a very strong desire to add fields to the existing m1AirPressure and m2AirPressure telemetry instead.
- Flesh out the Description and Units fields (including the units for pressure, which are Pa).
Attachments
Issue Links
- relates to
-
DM-17820 Update ATPneumatics simulator for changes to the XML
- Done
ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/67