Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17609

Improve ATPneumatics XML

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_dome
    • Labels:

      Description

      Improve the ATPneumatics XML as per disussion with Rolando Cantarutti

      • Ditch the Position events because they are fully duplicated by the limit switch events.
      • Add Invalid mirror cover state to handle the case that both an open and a closed switch are active for the same cover.
      • Ditch the overlap of the “state” enums with summary state and shorten the names to remove redundancy and stutter, so that the MirrorCoverState enums become:

        <Enumeration>MirrorCovers_Closed,MirrorCovers_Opened,MirrorCovers_InMotionState, MirrorCovers_Invalid</Enumeration>
        

        and the mirror vents state enum becomes:

        <Enumeration>CellVents_Opened,CellVents_Closed,CellVents_InMotion</Enumeration>
        

      • Delete the resetEStopTriggered event, rename the eStopTriggered event to eStopTrigger and set the triggered field appropriately.
      • Add two new events for reporting m1 and m2 commanded air pressure (each with a single field), unless folks have a very strong desire to add fields to the existing m1AirPressure and m2AirPressure telemetry instead.
      • Flesh out the Description and Units fields (including the units for pressure, which are Pa).

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/67
            Hide
            rowen Russell Owen added a comment -

            FYI: Dave Mills added support (on ts_xml develop branch) for <Description> fields for topics. I am taking advantage of that in this ticket. The code builds under ts_sal.

            Show
            rowen Russell Owen added a comment - FYI: Dave Mills added support (on ts_xml develop branch) for <Description> fields for topics. I am taking advantage of that in this ticket. The code builds under ts_sal.
            Hide
            rbovill Rob Bovill added a comment -

            ATPneumatics XML was updated as described.  changes merged to develop.  All tests behaving as expected.

            https://ts-ci.lsst.codes/job/ts_xml/1080/robot/report/report.html#

            Show
            rbovill Rob Bovill added a comment - ATPneumatics XML was updated as described.  changes merged to develop.  All tests behaving as expected. https://ts-ci.lsst.codes/job/ts_xml/1080/robot/report/report.html#
            Hide
            rbovill Rob Bovill added a comment -

            As part of marking this as Done, don't forget to delete the ticket branch.

            Show
            rbovill Rob Bovill added a comment - As part of marking this as Done, don't forget to delete the ticket branch.
            Hide
            rowen Russell Owen added a comment - - edited

            Thank you for the helpful review. Merged to develop and ticket branch deleted.

            Show
            rowen Russell Owen added a comment - - edited Thank you for the helpful review. Merged to develop and ticket branch deleted.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Rob Bovill
              Watchers:
              Patrick Ingraham, Rob Bovill, Rolando Cantarutti, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.