Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_middleware
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:TSSW Sprint - Feb 04 - Feb 16
-
Team:Telescope and Site
Description
Improve ATDome XML as per discussions with Patrick Ingraham and Paul.
Command changes:
- Add a homeAzimuth command.
- For the moveShutterDropoutDoor and moveShutterMainDoor commands replace the field with a boolean named open; the TCP/IP interface doesn't support partially opening or closing a door.
- Rename the stopAllAxis command to stopMotion.
- Remove the stopShutter and stopAzimuth commands; the TCP/IP interface only supports stopping all motion.
Event changes:
- Modify settingsAppliedDomeController as follows:
- Rename xActivated to xEnabled for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected.
- Remove the learnManual field; the TCP/IP interface does not provide the information.
- Add a homeAzimuth field to report the configured position of the home switch; this may be useful in conjunction with the homeAzimuth command and is output by the TCP/IP interface.
- Add a homing field to azimuthState. It could be made part of the state field but then we would need to treat the enums as bits for a bit mask and the XML doesn't seem to have good support for that.
- Modify settingsAppliedDomeTcp as follows:
- Change portRange field to port.
- Change ip to host and allow to be longer (to enable domain lookup).
- Remove writeTimeout; the CSC doesn't use it.
- Remove the following events, as we will not be outputting them:
- internalCommand
- loopTimeOutOfRange
- rejectedCommand
- internalStatus
- detailedState (and associated enum) because there is nothing to report beyond summaryState.
- Rename the allAxisInPosition event to allAxesInPosition.
Telemetry changes:
- Remove the following telemetry topics, as they are not output:
- loopTime
- timestamp telemetry topic; it is not output.
- Modify the position topic by renaming the dropout door fields from dropoutOpening... to dropoutDoorOpening... for consistency with the main door.
Enum changes:
- Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output.
- Remove the AzimuthState_InMotionState enum value; it cannot be output.
- Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output.
- Remove the redundant trailing State from AzimuthState_ and ShutterDoorState_ enums. For instance AzimuthState_NotInMotionState becomes AzimuthState_NotInMotion and ShutterDoorState_ClosedState becomes ShutterDoorState_Closed.
Attachments
Issue Links
Activity
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Description | Improve ATDome XML as per discussions with [~pingraham] and Paul. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. |
Status | To Do [ 10001 ] | In Progress [ 3 ] |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify se: * * Change portRange field to port in settingsAppliedDomeT * Remove the learnManual field from the settingsAppliedDomeController topic; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify se: * * Change portRange field to port in settingsAppliedDomeT * Remove the learnManual field from the settingsAppliedDomeController topic; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: * Change portRange field to port. * Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: * Change portRange field to port. * Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remote the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remote the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remote the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remote the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Rename the stopAllAxis command to stopMotion. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a home command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Rename the stopAllAxis command to stopMotion. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a homeAzimuth command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Rename the stopAllAxis command to stopMotion. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. * Add homeAzimuth field to the settingsAppliedDomeController event (the configured azimuth position of the home switch). |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Changes: * Add a homeAzimuth command. * Replace the moveShutterDropoutDoor and moveShutterMainDoor with one or two commands that only allow commanding each door fully open or closed; the TCP/IP interface doesn't support partially opening or closing a door. * Remove the stopShutter and stopAzimuth commands; the TCP/IP interface doesn't support them. * Rename the stopAllAxis command to stopMotion. * Modify the settingsAppliedDomeController topic as follows: ** Change portRange field to port. ** Remove the learnManual field from; the TCP/IP interface does not provide the information required to set it. * Remove the detailedState enum; detailed state has no information beyond summaryState. * Remove the following events, as we will not be outputting them: internalCommand, loopTimeOutOfRange, rejectedCommand, internalStatus. * Remove the detailedState event; there is nothing to report beyond summaryState. * Remove the loopTime telemetry topic; it is not output. * Remove the timestamp telemetry topic; it is not output. * Remove the ShutterDoorState_NotInMotionState enum value; it cannot be output. * Remove the AzimuthState_InMotionState enum value; it cannot be output. * Remove the AzimuthState_StoppingMotionState enum value; it cannot be reliably output. * Replace the inPosition field of shutterInPosition with mainDoorInPosition and dropoutDoorInPosition. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. * Add homeAzimuth field to the settingsAppliedDomeController event (the configured azimuth position of the home switch). |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Combine all four "in position" events into one: {{inPosition}}. * Combine {{dropoutDoorState}} and {{mainDoorState}} events into one: {{shutterState}}. * Modify {{settingsAppliedDomeController}} as follows: ** Remove the learnManual field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {internalStatus}} * Remove the {{detailedState}} event and associated enum because there is nothing to report beyond summaryState. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Other changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. * Add homeAzimuth field to the settingsAppliedDomeController event (the configured azimuth position of the home switch). |
Issue Type | Improvement [ 4 ] | Story [ 10001 ] |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Combine all four "in position" events into one: {{inPosition}}. * Combine {{dropoutDoorState}} and {{mainDoorState}} events into one: {{shutterState}}. * Modify {{settingsAppliedDomeController}} as follows: ** Remove the learnManual field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {internalStatus}} * Remove the {{detailedState}} event and associated enum because there is nothing to report beyond summaryState. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Other changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. * Rename the allAxisInPosition event to allAxesInPosition. * Rename xActivated to xEnabled for all fields in the settingsAppliedDomeController event. * Add homeAzimuth field to the settingsAppliedDomeController event (the configured azimuth position of the home switch). |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Add a {{homing}} field to {{azimuthState}}. It could be made part of the {{state}} field but then we would need to treat the enums as bits for a bit mask and the XML doesn't seem to have good support for that. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. * Modify the position topic by renaming the dropout door fields from dropoutOpening... to dropoutDoorOpening... for consistency with the main door. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Add a {{homing}} field to {{azimuthState}}. It could be made part of the {{state}} field but then we would need to treat the enums as bits for a bit mask and the XML doesn't seem to have good support for that. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. * Modify the position topic by renaming the dropout door fields from dropoutOpening... to dropoutDoorOpening... for consistency with the main door. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Add a {{homing}} field to {{azimuthState}}. It could be made part of the {{state}} field but then we would need to treat the enums as bits for a bit mask and the XML doesn't seem to have good support for that. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). ** Remove {{writeTimeout}}; the CSC doesn't use it. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. * Modify the position topic by renaming the dropout door fields from dropoutOpening... to dropoutDoorOpening... for consistency with the main door. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Reviewers | Eric Coughlin [ ecoughlin ] | |
Status | In Progress [ 3 ] | In Review [ 10004 ] |
Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Description |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Add a {{homing}} field to {{azimuthState}}. It could be made part of the {{state}} field but then we would need to treat the enums as bits for a bit mask and the XML doesn't seem to have good support for that. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). ** Remove {{writeTimeout}}; the CSC doesn't use it. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. * Modify the position topic by renaming the dropout door fields from dropoutOpening... to dropoutDoorOpening... for consistency with the main door. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. |
Improve ATDome XML as per discussions with [~pingraham] and Paul.
Command changes: * Add a {{homeAzimuth}} command. * For the {{moveShutterDropoutDoor}} and {{moveShutterMainDoor}} commands replace the field with a boolean named {{open}}; the TCP/IP interface doesn't support partially opening or closing a door. * Rename the {{stopAllAxis}} command to {{stopMotion}}. * Remove the {{stopShutter}} and {{stopAzimuth}} commands; the TCP/IP interface only supports stopping all motion. Event changes: * Modify {{settingsAppliedDomeController}} as follows: ** Rename {{xActivated}} to {{xEnabled}} for all fields because this indicates whether detecting the condition is enabled, not whether the condition is detected. ** Remove the {{learnManual}} field; the TCP/IP interface does not provide the information. ** Add a {{homeAzimuth}} field to report the configured position of the home switch; this may be useful in conjunction with the {{homeAzimuth}} command and is output by the TCP/IP interface. * Add a {{homing}} field to {{azimuthState}}. It could be made part of the {{state}} field but then we would need to treat the enums as bits for a bit mask and the XML doesn't seem to have good support for that. * Modify {{settingsAppliedDomeTcp}} as follows: ** Change portRange field to port. ** Change ip to host and allow to be longer (to enable domain lookup). ** Remove {{writeTimeout}}; the CSC doesn't use it. * Remove the following events, as we will not be outputting them: ** {{internalCommand}} ** {{loopTimeOutOfRange}} ** {{rejectedCommand}} ** {{internalStatus}} ** {{detailedState}} (and associated enum) because there is nothing to report beyond summaryState. * Rename the allAxisInPosition event to allAxesInPosition. Telemetry changes: * Remove the following telemetry topics, as they are not output: ** {{loopTime}} ** {{timestamp}} telemetry topic; it is not output. * Modify the position topic by renaming the dropout door fields from dropoutOpening... to dropoutDoorOpening... for consistency with the main door. Enum changes: * Remove the {{ShutterDoorState_NotInMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_InMotionState}} enum value; it cannot be output. * Remove the {{AzimuthState_StoppingMotionState}} enum value; it cannot be reliably output. * Remove the redundant trailing {{State}} from {{AzimuthState_}} and {{ShutterDoorState_}} enums. For instance {{AzimuthState_NotInMotionState}} becomes {{AzimuthState_NotInMotion}} and {{ShutterDoorState_ClosedState}} becomes {{ShutterDoorState_Closed}}. |
Resolution | Done [ 10000 ] | |
Status | Reviewed [ 10101 ] | Done [ 10002 ] |
End date | 05/Feb/19 | |
Start date | 01/Feb/19 |
ts_xml pull request: https://github.com/lsst-ts/ts_xml/pull/64