Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17659

Fix F632 flake8 warnings

    XMLWordPrintable

    Details

    • Story Points:
      0.5
    • Sprint:
      Arch 2019-02-04
    • Team:
      Architecture

      Description

      The new flake8 version warns about F632 (using is rather than ==) and this triggered a few flake8 failures over the weekend when the weekly tags were added.

      The full list I can find:

      qserv/admin/bin/qserv-parallel-cmd.py:191:12: F632 use ==/!= to compare str, bytes, and int literals
      		 
      meas_modelfit/python/lsst/meas/modelfit/display/cModelDisplay.py:34:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      meas_modelfit/python/lsst/meas/modelfit/display/cModelDisplay.py:36:10: F632 use ==/!= to compare str, bytes, and int literals
      		 
      daf_persistence/python/lsst/daf/persistence/butler.py:917:12: F632 use ==/!= to compare str, bytes, and int literals
      		 
      display_firefly/python/lsst/display/firefly/firefly.py:406:12: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/bin.src/compFakeGalaxy.py:184:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/bin.src/tractFindVisits.py:25:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/bin/compFakeGalaxy.py:184:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/bin/tractFindVisits.py:25:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/python/lsst/synpipe/positionGalSimFakes.py:74:12: F632 use ==/!= to compare str, bytes, and int literals
      		 
      ./synpipe/python/lsst/synpipe/positionGalSimFakes.py:133:20: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/python/lsst/synpipe/makeFakeGalaxy.py:32:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/python/lsst/synpipe/makeFakeGalaxy.py:41:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/python/lsst/synpipe/makeFakeGalaxy.py:52:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      synpipe/python/lsst/synpipe/makeFakeGalaxy.py:71:8: F632 use ==/!= to compare str, bytes, and int literals
      		 
      obs_lsstSim/python/lsst/obs/lsstSim/processCalibLsstSim.py:121:16: F632 use ==/!= to compare str, bytes, and int literals
      		 
      obs_lsstSim/python/lsst/obs/lsstSim/processCalibLsstSim.py:123:40: F632 use ==/!= to compare str, bytes, and int literals
      		 
      obs_lsstSim/python/lsst/obs/lsstSim/processCalibLsstSim.py:128:36: F632 use ==/!= to compare str, bytes, and int literals
      		 
      obs_lsstSim/python/lsst/obs/lsstSim/processCalibLsstSim.py:198:16: F632 use ==/!= to compare str, bytes, and int literals
      		 
      obs_lsstSim/python/lsst/obs/lsstSim/processCalibLsstSim.py:200:18: F632 use ==/!= to compare str, bytes, and int literals

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17675 Resolve flake8 errors in afw

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Link This issue relates to DM-17675 [ DM-17675 ]
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            tjenness Tim Jenness made changes -
            Assignee Tim Jenness [ tjenness ]
            tjenness Tim Jenness made changes -
            Sprint Arch 2019-02-04 [ 854 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Trivial fixes. No review.

            Show
            tjenness Tim Jenness added a comment - Trivial fixes. No review.
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Story Points 0.5

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Watchers:
              Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.