Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17672

Make ATAOS listen for pointing component instead of mount.

    XMLWordPrintable

    Details

      Description

      Instead of listening for the mount position from the ATMount, make ATAOS listen for the pointing component. 

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          tribeiro Tiago Ribeiro added a comment -

          Code is ready to be reviewed:

           

          https://github.com/lsst-ts/ts_ataos/pull/2

          Show
          tribeiro Tiago Ribeiro added a comment - Code is ready to be reviewed:   https://github.com/lsst-ts/ts_ataos/pull/2
          Hide
          Permalink
          rowen Russell Owen added a comment -

          This looks like a very useful enhancement. I put some suggestions on github.

          A more significant question that came up when I asked Patrick Ingraham about the driver for this code is that the M1 and M2 air pressure should perhaps be based on the current altitude instead of the target altitude. I don't think we know yet, so it is probably smarter to keep the code simple and use the target for everything (as you are doing). But it is worth noting this question somehow – perhaps has a ticket to evaluate that with on-telescope testing.

          Show
          rowen Russell Owen added a comment - This looks like a very useful enhancement. I put some suggestions on github. A more significant question that came up when I asked Patrick Ingraham about the driver for this code is that the M1 and M2 air pressure should perhaps be based on the current altitude instead of the target altitude. I don't think we know yet, so it is probably smarter to keep the code simple and use the target for everything (as you are doing). But it is worth noting this question somehow – perhaps has a ticket to evaluate that with on-telescope testing.
          Hide
          Permalink
          tribeiro Tiago Ribeiro added a comment -

          Code merged.

          https://github.com/lsst-ts/ts_ataos/releases/tag/v0.2

          Show
          tribeiro Tiago Ribeiro added a comment - Code merged. https://github.com/lsst-ts/ts_ataos/releases/tag/v0.2

            People

            Assignee:
            tribeiro Tiago Ribeiro
            Reporter:
            tribeiro Tiago Ribeiro
            Reviewers:
            Russell Owen
            Watchers:
            Andy Clements, James Buffill [X] (Inactive), Patrick Ingraham, Russell Owen, Tiago Ribeiro
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Start date:
              End date:

                Jenkins

                No builds found.