Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17675

Resolve flake8 errors in afw

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      The release of pycodestyle 2.5.0 has caused flake8 to be unhappy with the current master of afw. Please fix it.

      Unhappy flake8/Travis: https://travis-ci.org/lsst/afw/builds/488690857
      pycodestyle release notes: https://pypi.org/project/pycodestyle/2.5.0/
      Relevant Slack discussion: https://lsstc.slack.com/archives/C2JP8GGVC/p1549313396138300

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17659 Fix F632 flake8 warnings

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            PR: https://github.com/lsst/afw/pull/432
            Jenkins: https://ci.lsst.codes/job/stack-os-matrix/29386/

            I intend to merge without review when Jenkins is done.

            Show
            swinbank John Swinbank added a comment - PR: https://github.com/lsst/afw/pull/432 Jenkins: https://ci.lsst.codes/job/stack-os-matrix/29386/ I intend to merge without review when Jenkins is done.
            Hide
            Permalink
            swinbank John Swinbank added a comment - - edited

            Also PRs fixing E117 errors:

            Given that, this probably needs a proper review.

            Updated Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29391/pipeline

            Show
            swinbank John Swinbank added a comment - - edited Also PRs fixing E117 errors: https://github.com/lsst/ctrl_orca/pull/15 https://github.com/lsst/daf_persistence/pull/108 https://github.com/lsst/firefly_client/pull/3 https://github.com/lsst/meas_algorithms/pull/149 https://github.com/lsst/meas_deblender/pull/65 https://github.com/lsst/sconsUtils/pull/64 Given that, this probably needs a proper review. Updated Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29391/pipeline
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Jenkins is happy. Tim Jenness, are you?

            Show
            swinbank John Swinbank added a comment - Jenkins is happy. Tim Jenness , are you?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks great. Thanks.

            Show
            tjenness Tim Jenness added a comment - Looks great. Thanks.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Thanks for the fast turnaround, Tim. All done.

            Show
            swinbank John Swinbank added a comment - Thanks for the fast turnaround, Tim. All done.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              swinbank John Swinbank
              Reviewers:
              Tim Jenness
              Watchers:
              John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.