Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17689

Expose maximum number of bits used by IdFactory

    Details

      Description

      DM-15843 (pipe_tasks) uses the magic number "64" when construct afw.table.IdFactory instance as there is currently no programmatic way to go from the number of bits in a packed data ID to the amount that ID would need to be shifted to fit in the upper bits of a source ID.

      I'm deferring fixing that to another ticket to avoid a period in which the weekly can't be used with master of pipe_tasks (what that's not required by our workflow, it seems a good practice when it's easy to do, as it is here).

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Nate Lust, this is the spin-off from your comment about magic numbers on DM-15843.

            Changes in afw, obs_base, and pipe_tasks.

            I'm hoping to merge afw this week and the others next week to avoid any periods (at least due to these changes) in which downstream packages can't use an afw weekly.

            Show
            jbosch Jim Bosch added a comment - Nate Lust , this is the spin-off from your comment about magic numbers on DM-15843 . Changes in afw , obs_base , and pipe_tasks. I'm hoping to merge afw this week and the others next week to avoid any periods (at least due to these changes) in which downstream packages can't use an afw weekly.
            Hide
            swinbank John Swinbank added a comment -

            Hey Jim Bosch — this has been reviewed but not merged for most of this year. Can we close it out?

            Show
            swinbank John Swinbank added a comment - Hey Jim Bosch — this has been reviewed but not merged for most of this year. Can we close it out?
            Hide
            jbosch Jim Bosch added a comment -

            It breaks the SDSS demo because it changes some source IDs.  At this point I've been thinking I'll just wait until that's gone, now that it's been RFC'd, and then update the changes here to reflect the stuff that's changed underneath it.

            Show
            jbosch Jim Bosch added a comment - It breaks the SDSS demo because it changes some source IDs.  At this point I've been thinking I'll just wait until that's gone, now that it's been RFC'd, and then update the changes here to reflect the stuff that's changed underneath it.
            Hide
            swinbank John Swinbank added a comment -

            Show
            swinbank John Swinbank added a comment -

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Nate Lust
                Watchers:
                Jim Bosch, John Swinbank, Nate Lust
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Summary Panel