Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17726

Update flake8 and pycodestyle to support max-doc-length

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Third Party Software
    • Labels:
      None
    • Story Points:
      3
    • Sprint:
      Arch 2019-02-04
    • Team:
      Architecture

      Description

      With the release of new versions of pycodestyle and flake8 that support max-doc-length, we can update our eups packages to allow packages to use max-doc-length in their setup.cfg files.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-18018 Please update pycodestyle

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16162 Patch flake8 to support W505

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue relates to DM-16162 [ DM-16162 ]
            tjenness Tim Jenness made changes -
            Watchers Brian Van Klaveren, Jonathan Sick, Kian-Tat Lim, Tim Jenness [ Brian Van Klaveren, Jonathan Sick, Kian-Tat Lim, Tim Jenness ] Brian Van Klaveren, John Swinbank, Jonathan Sick, Kian-Tat Lim, Tim Jenness [ Brian Van Klaveren, John Swinbank, Jonathan Sick, Kian-Tat Lim, Tim Jenness ]
            tjenness Tim Jenness made changes -
            Story Points 1 3
            tjenness Tim Jenness made changes -
            Component/s Third Party Software [ 11312 ]
            Sprint Arch 2019-02-04 [ 854 ]
            tjenness Tim Jenness made changes -
            Assignee Tim Jenness [ tjenness ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I have included a pep8-naming update on this ticket. This has proven to be problematic since many new checks were added and most of our software fails them.

            Show
            tjenness Tim Jenness added a comment - I have included a pep8-naming update on this ticket. This has proven to be problematic since many new checks were added and most of our software fails them.
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim can you have a look at this please? lsst_distrib builds with the new flake8 and associated packages. I will update the dev guide to add the new N codes that got added to the ignore list.

            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim can you have a look at this please? lsst_distrib builds with the new flake8 and associated packages. I will update the dev guide to add the new N codes that got added to the ignore list.
            tjenness Tim Jenness made changes -
            Reviewers Kian-Tat Lim [ ktl ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            I approve of the dev guide changes. It's interesting that W504 doesn't seem to have propagated throughout. It's also unfortunate that we have so many repetitions of the list that need to be updated.

            I suggest that lsst/templates should also be updated; other than that, this looks OK to merge.

            Show
            ktl Kian-Tat Lim added a comment - I approve of the dev guide changes. It's interesting that W504 doesn't seem to have propagated throughout. It's also unfortunate that we have so many repetitions of the list that need to be updated. I suggest that lsst/templates should also be updated; other than that, this looks OK to merge.
            ktl Kian-Tat Lim made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I agree completely that changing every setup.cfg to sync up the error codes is not a good approach (50 pull requests on this ticket demonstrate that). A better plan would be wonderful.

            Show
            tjenness Tim Jenness added a comment - I agree completely that changing every setup.cfg to sync up the error codes is not a good approach (50 pull requests on this ticket demonstrate that). A better plan would be wonderful.
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment - - edited

            I was only referring to the number of repetitions of the list within the Dev Guide, not even the setup.cfg files in the other repos.

            Show
            ktl Kian-Tat Lim added a comment - - edited I was only referring to the number of repetitions of the list within the Dev Guide , not even the setup.cfg files in the other repos.
            tjenness Tim Jenness made changes -
            Link This issue is duplicated by DM-18018 [ DM-18018 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Brian Van Klaveren, John Swinbank, Jonathan Sick, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.