Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17775

ATMCS should not enable unused axes

    XMLWordPrintable

    Details

      Description

      At present the ATMCS CSC enables all axes when the summary state is Enabled. Unfortunately this includes the M3 rotator and also both instrument rotators. We should turn off power to drive motors that we are not using, unless the actuators go into an extremely low power mode when they aren't doing anything. Otherwise we generate unnecessary heat in the enclosure, which harms image quality due to roiling the air.

      I propose the following solution:
      1) Only enable the M3 rotator drive when executing the setInstrumentPort command.
      2) The Nasmyth rotator drives are trickier because we might want to move one for engineering purposes regardless of the position of M3. So I suggest that we normally disable any rotator drive that M3 is not pointing at (that would be one or both rotators, depending on the instrument port). However, we also add new commands that lets us move either rotator for engineering purposes (not a command that the pointing component would ever send). If we can safely move a drive and then disable it and it will stay then it can be a pair of move commands (one per port) accept a position. The command enables that drive, moves the drive, and disables the drive (engaging the brake). I would also suggest that the command be prohibited for the current port IF tracking is enabled. (No need to prohibit it if the M3 is pointing to the other port, as there is no conflict). Full error handling will take a bit of work since we should also prohibit enabling tracking while executing the command, or moving M3 to that port while tracking...

      I also propose that we prohibit moving M3 while tracking is enabled.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment - - edited

            Rolando Cantarutti what is your plan to implement this? Is it just an internal change, such as changing the rules as to when a rotator axis is enabled or disabled, or will you need changes to the MCS XML or to the data in the commands sent by ATPtg? I want to to update ATMCS simulator to match (DM-190251), once I know what to do.

            Show
            rowen Russell Owen added a comment - - edited Rolando Cantarutti what is your plan to implement this? Is it just an internal change, such as changing the rules as to when a rotator axis is enabled or disabled, or will you need changes to the MCS XML or to the data in the commands sent by ATPtg? I want to to update ATMCS simulator to match (DM-190251), once I know what to do.
            Hide
            aclements Andy Clements added a comment -

            Russell Owen I believe Rolando needs to work on this ticket, not Andres Anania [X].   He currently has other priorities.

            Show
            aclements Andy Clements added a comment - Russell Owen I believe Rolando needs to work on this ticket, not Andres Anania [X] .   He currently has other priorities.
            Hide
            tribeiro Tiago Ribeiro added a comment -

            I'm under the impression that this is done. As far as I know, and saw in Chile, only the active axes are initialized by the real ATMCS.

            Show
            tribeiro Tiago Ribeiro added a comment - I'm under the impression that this is done. As far as I know, and saw in Chile, only the active axes are initialized by the real ATMCS.
            Hide
            pingraham Patrick Ingraham added a comment -

            I agree that it is complete.

            Show
            pingraham Patrick Ingraham added a comment - I agree that it is complete.
            Hide
            aclements Andy Clements added a comment -

            This sounds done Russell can we close it?

            Show
            aclements Andy Clements added a comment - This sounds done Russell can we close it?
            Hide
            rowen Russell Owen added a comment - - edited

            I defer to Tiago Ribeiro. I have not used the real ATMCS but Rolando Cantarutti told me what he intended to implement and based on Tiago Ribeiro's tests it sounds as if he has done it. I am happy to have this closed.

            Show
            rowen Russell Owen added a comment - - edited I defer to Tiago Ribeiro . I have not used the real ATMCS but Rolando Cantarutti told me what he intended to implement and based on Tiago Ribeiro 's tests it sounds as if he has done it. I am happy to have this closed.
            Hide
            jbuffill James Buffill [X] (Inactive) added a comment -

            Done

            Show
            jbuffill James Buffill [X] (Inactive) added a comment - Done

              People

              Assignee:
              tribeiro Tiago Ribeiro
              Reporter:
              rowen Russell Owen
              Reviewers:
              Russell Owen
              Watchers:
              Andy Clements, James Buffill [X] (Inactive), Patrick Ingraham, Rolando Cantarutti, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.