# fix faint source and minimum-radius problems in Kron photometry

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
5
• Team:
Data Release Production

#### Description

This transfers some improvements to the Kron photometry from the HSC side:

• HSC-983: address failures on faint sources
• HSC-989: fix the minimum radius
• HSC-121: fix scaling in forced photometry

The story points estimate here is 50% of the actual effort, as the work (already done) also benefited HSC.

#### Activity

Hide
Jim Bosch added a comment -

This issue is composed entirely of commits created by Paul Price and cherry-picked by me, so I'm just going to review them myself. It's unlikely I'll find anything anyway, as all of this has already gone through code review on the HSC side.

Show
Jim Bosch added a comment - This issue is composed entirely of commits created by Paul Price and cherry-picked by me, so I'm just going to review them myself. It's unlikely I'll find anything anyway, as all of this has already gone through code review on the HSC side.
Hide
Jim Bosch added a comment -

Just modified some whitespace:

 commit be25e90d511e180af705528b531d81b657ffdbff Author: Jim Bosch  Date: Mon Jan 26 10:07:32 2015 -0500    Whitespace cleanups and copyright update.    Removed trailing whitespace, fixed lines longer than 110 columns, and  updated the copyright text to 2015 (and added it to some files that  previously lacked it).    include/lsst/meas/extensions/photometryKron.h | 23 ++++-  .../meas/extensions/photometryKron/__init__.py | 14 +--  .../lsst/meas/extensions/photometryKron/kronLib.i | 3 +-  src/KronPhotometry.cc | 95 ++++++++++++++------  tests/Kron.py | 38 ++++++--  5 files changed, 127 insertions(+), 46 deletions(-)

There were also some variables using underscores (which mostly predated these changes), but in this case I think they improved readability by connecting the variable names better to the mathematics involved, so I'm going to pretend I have the authority to grant an exception to the standards in this case.

Show
Jim Bosch added a comment - Just modified some whitespace: commit be25e90d511e180af705528b531d81b657ffdbff Author: Jim Bosch <jbosch@astro.princeton.edu> Date: Mon Jan 26 10:07:32 2015 -0500   Whitespace cleanups and copyright update. Removed trailing whitespace, fixed lines longer than 110 columns, and updated the copyright text to 2015 (and added it to some files that previously lacked it).   include/lsst/meas/extensions/photometryKron.h | 23 ++++- .../meas/extensions/photometryKron/__init__.py | 14 +-- .../lsst/meas/extensions/photometryKron/kronLib.i | 3 +- src/KronPhotometry.cc | 95 ++++++++++++++------ tests/Kron.py | 38 ++++++-- 5 files changed, 127 insertions(+), 46 deletions(-) There were also some variables using underscores (which mostly predated these changes), but in this case I think they improved readability by connecting the variable names better to the mathematics involved, so I'm going to pretend I have the authority to grant an exception to the standards in this case.

#### People

Assignee:
Jim Bosch
Reporter:
Jim Bosch
Reviewers:
Jim Bosch
Watchers:
Jim Bosch, John Swinbank, Perry Gee