Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17837

Fix incorrect detector serial in TS8 RTM-004

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_lsst
    • Labels:
      None
    • Story Points:
      0.5
    • Sprint:
      Arch 2019-02-04, Arch 2019-02-11
    • Team:
      Architecture

      Description

      Andrés Alejandro Plazas Malagón noticed that ingestion of TS8 RTM-004 was failing. It seems I mistyped 285 for 385 in the detector serial of S20. Fix the typo and the associated bug that cascaded in the error handling from this.

        Attachments

          Issue Links

            Activity

            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            I see you've asked for a review on GitHub but haven't marked this as in review or even in progress here (presumably because of the ongoing work going over all the datasets and adding in the required values).

            Once that's done just stick it in review on here and I'll do it.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I see you've asked for a review on GitHub but haven't marked this as in review or even in progress here (presumably because of the ongoing work going over all the datasets and adding in the required values). Once that's done just stick it in review on here and I'll do it.
            Hide
            tjenness Tim Jenness added a comment -

            Exactly. Once I realised that TS8 needed to be tested for all the data this went from a quick ticket to a longer one. If Andrés Alejandro Plazas Malagón needs me to merge this quickly please let me know.

            Show
            tjenness Tim Jenness added a comment - Exactly. Once I realised that TS8 needed to be tested for all the data this went from a quick ticket to a longer one. If Andrés Alejandro Plazas Malagón needs me to merge this quickly please let me know.
            Hide
            tjenness Tim Jenness added a comment -

            I'm still going through the data but the core of the changes are now in place and ready for review. The only changes that I foresee are more CONTNUM values.

            Show
            tjenness Tim Jenness added a comment - I'm still going through the data but the core of the changes are now in place and ready for review. The only changes that I foresee are more CONTNUM values.
            Hide
            tjenness Tim Jenness added a comment -

            I've tested with all the TS8 data in /datasets/ts8 and they all get recognized as TS8 now.

            Show
            tjenness Tim Jenness added a comment - I've tested with all the TS8 data in /datasets/ts8 and they all get recognized as TS8 now.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Merlin Fisher-Levine
                Watchers:
                Andrés Alejandro Plazas Malagón, Merlin Fisher-Levine, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel