Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_extensions_photometryKron
-
Labels:None
-
Story Points:5
-
Epic Link:
-
Team:Data Release Production
Description
This transfers some improvements to the Kron photometry from the HSC side:
- HSC-983: address failures on faint sources
- HSC-989: fix the minimum radius
- HSC-865: switch to determinant radius instead of semimajor axis
- HSC-962: bad radius flag was not being used
- HSC-121: fix scaling in forced photometry
The story points estimate here is 50% of the actual effort, as the work (already done) also benefited HSC.
Attachments
Issue Links
- blocks
-
- Done
Activity
| Description |
This transfers some improvements to the Kron photometry from the HSC side: - HSC-983: address failures on faint sources - HSC-989: fix the minimum radius The story points estimate here is 50% of the actual effort, as the work (already done) also benefited HSC. |
This transfers some improvements to the Kron photometry from the HSC side: - HSC-983: address failures on faint sources - HSC-989: fix the minimum radius - HSC-865: switch to determinant radius instead of semimajor axis - HSC-962: bad radius flag was not being used - HSC-121: fix scaling in forced photometry The story points estimate here is 50% of the actual effort, as the work (already done) also benefited HSC. |
| Story Points | 3 | 5 |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Reviewers | Jim Bosch [ jbosch ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Just modified some whitespace:
commit be25e90d511e180af705528b531d81b657ffdbff
|
Author: Jim Bosch <jbosch@astro.princeton.edu>
|
Date: Mon Jan 26 10:07:32 2015 -0500
|
|
|
Whitespace cleanups and copyright update.
|
|
Removed trailing whitespace, fixed lines longer than 110 columns, and
|
updated the copyright text to 2015 (and added it to some files that
|
previously lacked it).
|
|
|
include/lsst/meas/extensions/photometryKron.h | 23 ++++-
|
.../meas/extensions/photometryKron/__init__.py | 14 +--
|
.../lsst/meas/extensions/photometryKron/kronLib.i | 3 +-
|
src/KronPhotometry.cc | 95 ++++++++++++++------
|
tests/Kron.py | 38 ++++++--
|
5 files changed, 127 insertions(+), 46 deletions(-)
|
There were also some variables using underscores (which mostly predated these changes), but in this case I think they improved readability by connecting the variable names better to the mathematics involved, so I'm going to pretend I have the authority to grant an exception to the standards in this case.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
| Component/s | meas_extensions_photometryKron [ 12318 ] | |
| Component/s | meas_extensions_kron [ 10737 ] |
This issue is composed entirely of commits created by Paul Price and cherry-picked by me, so I'm just going to review them myself. It's unlikely I'll find anything anyway, as all of this has already gone through code review on the HSC side.