On TSS-3366 at tribeiro's request I changed MTPtg and ATPgt XML to PointingComponent. This ticket is to request that the vendor-supplied code be updated accordingly.
This is also a good opportunity to clean up the XML further. Some issues:
- Item name "localTime" is disallowed because it is an SQL reserved word. See https://confluence.lsstcorp.org/display/SYSENG/SAL+constraints+and+recommendations
- Some of the documentation is dead wrong. For instance parAngle is described as "Local Time (UTC) as a sexagesimal string (HH:MM:SS.SSS)". Clearly a copy/paste error. In another case a parameter named localTime is described as "Local time (UTC)..." which is not self-consistent. But see my comment on time output below.
- Most items need Units to be specified
- Time output would benefit from a major overhaul:
- SAL messages already contain a timestamp for the time at which they were sent. Thus a separate timestamp is only relevant if you need to specify the time at which the data was collected. If the data is slowly varying then the default time-sent timestamp is good enough.
- Many topics send different kinds of time (e.g. UTC, MJD, JD, formatted string versions...) and this is unnecessary and a waste of bandwidth and EFD storage. The whole observatory works in TAI in seconds from the unix epoch, as output by SAL getCurrentTime(). Please only output time information in this format. Note that the computer on which this software runs will be synchronized to TAI using PTP.
One instance where we want time information than TAI is output of earth orientation data In that case all we need is UT1-TAI, UTC-TAI and the TAI at which these are valid. This is a good example of a situation where an explicit timestamp is preferred over the date at which the SAL message is sent, because UTC-TAI is discontinuous and the exact TAI may matter. Technically we could live without UTC-TAI but it's useful to have and provides a sanity check.