Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17873

Deprecated hasX() methods in ExposureInfo

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      2

      Description

      While working on replacing Calib with PhotoCalib, I noticed the various hasXxx methods in ExposureInfo. It's not clear that these have any real utility: they're just checking whether the shared_ptr is null. Jim Bosch suggested that "we should either remove all or none of them", and "all" is out of scope for DM-10156. We should be able to deprecate all of these.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-10156 Replace all uses of Calib with PhotoCalib

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            We use hasWcs and hasPsf in a few places outside of afw tests. We don't really use the others. We did add a new hasX method last year for hasSummaryStats. Removing all usage doesn't seem like a lot of work. This would need an RFC.

            Show
            tjenness Tim Jenness added a comment - We use hasWcs and hasPsf in a few places outside of afw tests. We don't really use the others. We did add a new hasX method last year for hasSummaryStats . Removing all usage doesn't seem like a lot of work. This would need an RFC.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Since we can just check that the returned property is None, the `hasX` methods don't really gain anything in python. There are some uses in C++ that might have to be refactored.

            Show
            Parejkoj John Parejko added a comment - Since we can just check that the returned property is None, the `hasX` methods don't really gain anything in python. There are some uses in C++ that might have to be refactored.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I think all the C++ usage is similarly easy, because None <=> nullptr in all of these cases.  That said, I don't really see us prioritizing this and I have no plans to make an RFC for it.  Anyone watching who really wants it is welcome to, but if this comes back to the CCB one more time I think we just Won't Fix it.

            Show
            jbosch Jim Bosch added a comment - I think all the C++ usage is similarly easy, because None <=> nullptr in all of these cases.  That said, I don't really see us prioritizing this and I have no plans to make an RFC for it.  Anyone watching who really wants it is welcome to, but if this comes back to the CCB one more time I think we just Won't Fix it.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Jim Bosch, John Parejko, Paul Price, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.