Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17932

Validate object type when reading pipeline or graph from pickle

    Details

    • Story Points:
      1
    • Sprint:
      DB_S19_02, DB_S19_03, DB_S19_04
    • Team:
      Data Access and Database

      Description

      cmdLineFwk can read pre-built pipeline and quantum graph from pickle file, but it is not presently checking that object of correct type is read which can lead to exceptions in other places. Need to add simple check of the type of the object that was read.

        Attachments

          Activity

          Hide
          salnikov Andy Salnikov added a comment -

          Nate Lust could you look at this? The fix is trivial, unit test for it is longer but still sort of trivial. Jenkins is still building this branch, but I don't think anything in lsst_distrib depends on that piece of code.

          Show
          salnikov Andy Salnikov added a comment - Nate Lust could you look at this? The fix is trivial, unit test for it is longer but still sort of trivial. Jenkins is still building this branch, but I don't think anything in lsst_distrib depends on that piece of code.
          Hide
          nlust Nate Lust added a comment -

          A few minor comments, sorry for the delay in getting to this review

          Show
          nlust Nate Lust added a comment - A few minor comments, sorry for the delay in getting to this review
          Hide
          salnikov Andy Salnikov added a comment -

          Thanks for review! I removed unused variables, merged and done.

          Show
          salnikov Andy Salnikov added a comment - Thanks for review! I removed unused variables, merged and done.

            People

            • Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Nate Lust
              Watchers:
              Andy Salnikov, Nate Lust, Vaikunth Thukral
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel