Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17947

Remove the unused MultiBandDataIdContainer

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_drivers
    • Labels:
      None

      Description

      MultiBandDataIdContainer is not used anywhere and is duplicate of TractDataIdContainer in pipe/drivers/utils.py. I suggest removing it to make the occasional debug less confusing.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          hchiang2 Hsin-Fang Chiang added a comment -

          Would you mind reviewing this cleanup? 

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Would you mind reviewing this cleanup? 
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          +1 for removing unused/duplicated code (although I’ll note it’s not an exact duplicate as it does not do the validKeys dance...but I don’t think that’s a problem!)

          I suggest you squash the two commits, otherwise you’re good to go.

          Show
          lauren Lauren MacArthur added a comment - +1 for removing unused/duplicated code (although I’ll note it’s not an exact duplicate as it does not do the  validKeys dance...but I don’t think that’s a problem!) I suggest you squash the two commits, otherwise you’re good to go.
          Hide
          Permalink
          hchiang2 Hsin-Fang Chiang added a comment -

          Thank you for reviewing! 

           

          Squashed and merged.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Thank you for reviewing!    Squashed and merged.

            People

            Assignee:
            hchiang2 Hsin-Fang Chiang
            Reporter:
            hchiang2 Hsin-Fang Chiang
            Reviewers:
            Lauren MacArthur
            Watchers:
            Hsin-Fang Chiang, Lauren MacArthur
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.