Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-17960

Test FFT PSF convolution algorithms

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_deblender
    • Labels:
      None
    • Story Points:
      12
    • Sprint:
      DRP S19-3, DRP S19-4
    • Team:
      Data Release Production

      Description

      Before DM-17748 is completed it was deemed useful to test the efficiency and accuracy of different convolution and translation algorithms. This ticket documents that work, including investigating different algorithms, the creation of a diagnostics section to scarlet and a notebook that demonstrates the new algorithms which has been added to the torch directory in scarlet.

        Attachments

          Activity

          Hide
          fred3m Fred Moolekamp added a comment - - edited

          Hi Peter,
          Can you have a look at this ticket for me (see the PR on github). Unfortunately pytorch is one dependency too many and importing all of the modules we uses uses up too much memory, so read the docs cannot build the new diagnostics page. We'll still have to decide what to do about hosting this information. We could switch to github pages for our docs, but that only builds the master docs and doesn't allow for multiple versions, so it still isn't an ideal solution.

          -Fred

          Show
          fred3m Fred Moolekamp added a comment - - edited Hi Peter, Can you have a look at this ticket for me (see the PR on github). Unfortunately pytorch is one dependency too many and importing all of the modules we uses uses up too much memory, so read the docs cannot build the new diagnostics page. We'll still have to decide what to do about hosting this information. We could switch to github pages for our docs, but that only builds the master docs and doesn't allow for multiple versions, so it still isn't an ideal solution. -Fred
          Hide
          fred3m Fred Moolekamp added a comment -

          I removed the dependence on pytorch, so the diagnostics are still built in the docs using numpy FFT's on RTD, however pulling the branch locally can execute the pytorch version. See the docs.

          Show
          fred3m Fred Moolekamp added a comment - I removed the dependence on pytorch, so the diagnostics are still built in the docs using numpy FFT's on RTD, however pulling the branch locally can execute the pytorch version. See the docs .
          Hide
          pmelchior Peter Melchior added a comment -

          Thanks for testing those. Both interpolation and convolution can be implemented for SCARLET and should be beneficial for performance and possibly overall code complexity

          Show
          pmelchior Peter Melchior added a comment - Thanks for testing those. Both interpolation and convolution can be implemented for SCARLET and should be beneficial for performance and possibly overall code complexity

            People

            • Assignee:
              fred3m Fred Moolekamp
              Reporter:
              fred3m Fred Moolekamp
              Reviewers:
              Peter Melchior
              Watchers:
              Fred Moolekamp, John Swinbank, Peter Melchior
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: