Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18018

Please update pycodestyle

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: stack release
    • Labels:
      None
    • Team:
      Architecture

      Description

      The version of pycodestyle in our stack release is 2.3.1 and it has a serious bug that is plaguing Telescope and Site:

        /opt/lsst/software/stack/stack/miniconda3-4.3.21-10a4fa6/Linux64/pycodestyle/2.3.1+3/lib/python/pycodestyle-2.3.1-py3.6.egg/pycodestyle.py:127: DeprecationWarning: invalid escape sequence \s
      		 
          r'^\s*({0})'.format('|'.join(s.replace(' ', '\s+') for s in (

      Please update to a more recent version. The current version appears to be 2.5.0 based on https://github.com/PyCQA/pycodestyle/blob/master/CHANGES.txt

        Attachments

          Issue Links

          duplicates

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-16296 Update flake8/pycodestyle

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-17726 Update flake8 and pycodestyle to support max-doc-length

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This is not a bug. pycodestyle was updated in DM-17726.

            Show
            tjenness Tim Jenness added a comment - This is not a bug. pycodestyle was updated in DM-17726 .
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            See also the discussion on community: https://community.lsst.org/t/changes-to-flake8-and-doc-string-checking/3585

            Show
            tjenness Tim Jenness added a comment - See also the discussion on community: https://community.lsst.org/t/changes-to-flake8-and-doc-string-checking/3585
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Also, why is a DeprecationWarning seen as a bug?

            Show
            tjenness Tim Jenness added a comment - Also, why is a DeprecationWarning seen as a bug?
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Sorry for the too-late ticket; I'm glad you already updated pycodestyle.

            The reason the DeprecationWarning is a bug is that it somehow stops scons from running (or at least displaying) the coverage test. So from my perspective it is a bug in that it prevents me from seeing important information.

            Also if ts_salobj actually has a code violation then I want to know about it. (Though flake8 on my Mac shows no problems, so I don't actually know if there is a problem in ts_salobj or not).

            Show
            rowen Russell Owen added a comment - - edited Sorry for the too-late ticket; I'm glad you already updated pycodestyle. The reason the DeprecationWarning is a bug is that it somehow stops scons from running (or at least displaying) the coverage test. So from my perspective it is a bug in that it prevents me from seeing important information. Also if ts_salobj actually has a code violation then I want to know about it. (Though flake8 on my Mac shows no problems, so I don't actually know if there is a problem in ts_salobj or not).
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Ah. I remember now. Sorry, I fixed that problem so long ago I had forgotten about it. I fixed that problem 4 months ago in DM-16296 when I updated pycodestyle to v2.4.0.

            Show
            tjenness Tim Jenness added a comment - Ah. I remember now. Sorry, I fixed that problem so long ago I had forgotten about it. I fixed that problem 4 months ago in DM-16296 when I updated pycodestyle to v2.4.0.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rowen Russell Owen
              Watchers:
              Russell Owen, Tiago Ribeiro, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.