Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-18067

Add fluxMag0 PhotoCalib factory function

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw

      Description

      While working on DM-10156, I found that it would in fact be useful to have a factory function that took the Calib-style fluxMag0/fluxMag0Err and returned a PhotoCalib. I implemented it on that ticket, but it stands alone, so I'm going to cherry-pick it here to save the poor reviewer of DM-10156 a little bit of effort.

        Attachments

          Issue Links

            Activity

            No builds found.
            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Epic Link DM-10153 [ 31778 ]
            Parejkoj John Parejko made changes -
            Link This issue blocks DM-10156 [ DM-10156 ]
            Hide
            Parejkoj John Parejko added a comment -

            Krzysztof Findeisen, would you be willing to review this ~50 line change? I pulled it out of DM-10156 to make that one a bit more tractable.

            One question I have is whether we should follow the C++ overload convention, or whether I should rename the new function to e.g. makePhotoCalibFromZeroPoint() to make the intention clearer in python (where it would primarily be used)?

            Show
            Parejkoj John Parejko added a comment - Krzysztof Findeisen , would you be willing to review this ~50 line change? I pulled it out of DM-10156 to make that one a bit more tractable. One question I have is whether we should follow the C++ overload convention, or whether I should rename the new function to e.g. makePhotoCalibFromZeroPoint() to make the intention clearer in python (where it would primarily be used)?
            Parejkoj John Parejko made changes -
            Reviewers Krzysztof Findeisen [ krzys ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/29463/pipeline
            Parejkoj John Parejko made changes -
            Assignee John Parejko [ parejkoj ]
            Hide
            krzys Krzysztof Findeisen added a comment -

            Please don't say "C++ overload convention", I'm pretty sure there's no such rule. for giving a descriptive name, otherwise minor comments.

            Show
            krzys Krzysztof Findeisen added a comment - Please don't say "C++ overload convention", I'm pretty sure there's no such rule. for giving a descriptive name, otherwise minor comments.
            krzys Krzysztof Findeisen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-3 [ 831 ] AP S19-3, AP S19-4 [ 831, 832 ]
            Hide
            Parejkoj John Parejko added a comment -

            Thank you for the review.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Thank you for the review. Merged and done.
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Link This issue is triggering DM-18354 [ DM-18354 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, John Parejko, John Swinbank, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.